348115 - bg Bulgarian Search Feature Tracking for Firefox 2

Status: VERIFIED FIXED

(Mozilla Localizations :: bg / Bulgarian, defect)

Description

[chris hofmann]

tracking bug to make sure we get things on the list below working correctly for
each locale:

Full Default Search partner list/order.
primary/secondary search selection behavior
Search codes.
Search Suggests enable/disable for locales where available or not

Comment 1

[Axel Hecht [:Pike]]

Ogi, comparing to 1.5 and the comments in bug 315681, I guess we'd like to add back the wikipedia plugin for bg.
See http://developer.mozilla.org/en/docs/Creating_MozSearch_plugins on how to create those.

I don't think there's a local presence of Yahoo in Bulgria, I'm fine with keeping that, if you think it's good.

Mic, any comments from your side?

Comment 2

[Axel Hecht [:Pike]]

PS: http://lxr.mozilla.org/l10n-mozilla1.8/source/bg/browser/chrome/browser-region/region.properties#7 should be

browser.search.order.1=Google

Otherwise, the order won't be picked up with the (correctly used) en-US google plugin.

Comment 3

[chris hofmann]

http://people.mozilla.com/~axel/nightly-1.8/search-engines.html
shows incorrect ordering information.

from http://lxr.mozilla.org/l10n-mozilla1.8/source/bg/browser/chrome/browser-region/region.properties
it appears that Google.bg needs to be changed to Google

  4 # Search engine order (order displayed in the search bar dropdown)s
  5 browser.search.order.1=Google.bg
  6 browser.search.order.2=Yahoo

look

Comment 4

[chris hofmann]

bugzilla seems to have cut my last comment

seem that http://bg.search.yahoo.com/ isn't supported so yahoo stuff should be removed.

Comment 5

[chris hofmann]

recording what is in beta 2 build...
Идентификатор на компилирането:Mozilla/5.0 (Windows; U; Windows NT 5.1; bg; rv:1.8.1b2) Gecko/2006082101 Firefox/2.0b2


Yahoo
http://search.yahoo.com/search?p=test&ei=UTF-8&fr=moz2

Google
http://www.google.com/search?q=test&ie=utf-8&oe=utf-8&rls=org.mozilla:bg:official&client=firefox-a

Comment 6

[chris hofmann]

Link to what was reviewed for 1.5.

https://bugzilla.mozilla.org/show_bug.cgi?id=315681#c2

Comment 7

[chris hofmann]

search suggests appears enabled for both google and yahoo in the b2 build... 

need to figure out what we are going to do and start locking this down for final.

Comment 8

[Axel Hecht [:Pike]]

Ogi, could we get the search order fixed?

We'd like to get your comment on adding back wikipedia, too. You'd need to create a MozSearch plugin for that, should be easy, there are plenty of those in the l10n repository.

Comment 9

[Mic Berman]

Hi
adding wikipedia is fine (comment #1)
order of search engine's beyond Google in #1 position is up to your discretion
thanks,
mic

Comment 10

[Mic Berman]

Hi
adding wikipedia is fine (comment #1)
order of search engine's beyond Google in #1 position is up to your discretion
thanks,
mic

Comment 11

[Ognyan Kulev]

I'm sorry for being unresponsive recently. I'll try to address the important problems of bg l10n this weekend.

Comment 12

[Mic Berman]

note to all: this has been reviewed for FF2 from BD and is good to go, meaning ok to remove Yahoo, put wikipedia back

thanks
mic

Comment 13

[Ognyan Kulev]

Attachment: Try to set 1.Google 2.Wikipedia-bg

Wikipedia is not shown in the list and I don't know why :-(

Comment 14

[Axel Hecht [:Pike]]

Comment on attachment 238265 [details] [diff] [review]
Try to set 1.Google 2.Wikipedia-bg

r=me with the following nits:

Please just remove the 
browser.search.order.2=Yahoo
line, don't add ordering for Wikipedia.

list.txt looks good.

as for the wikipedia-bg plugin, try opening as file in mozilla, that should show you if there are any xml parsing errors left.
If that looks ok, just land the plugin, even if you think it might have problem, and we'll take it from there.

Comment 15

[Ognyan Kulev]

https://bugzilla.mozilla.org/attachment.cgi?id=238265 is committed, with only Google in search order.

Comment 16

[Axel Hecht [:Pike]]

FIXED, thanks. Could you please test this in a nightly and a fresh profile and VERIFY that all plugins work as expected?

Comment 17

[Ognyan Kulev]

Tested and both searchplugins (Google and Wikipedia.bg) work as expected.