Closed Bug 348137 Opened 14 years ago Closed 14 years ago

CTRL+F hotkey not mapped, search function text field not selected

Categories

(Calendar :: Sunbird Only, defect, minor)

x86
Windows 2000
defect
Not set
minor

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: fc012890, Assigned: jminta)

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; nl; rv:1.8.0.3) Gecko/20060426 Firefox/1.5.0.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060507 Mozilla Sunbird/0.3a2

Pressing CTRL+F shortcut key to access calender event search function, doesn't result in any action.  Search text field doesn't get selected or cursor is not appearing in the text field.  Most programs use the CTRL+F hotkey to access a search function.  Users who see "search" and are used to shortcut keys will not see any actions and are forced to use the mouse.  TAB is one option, but it can take a long while before the cursor gets positioned in the search text field, depending on where the cursor is located in the calender screen.

Reproducible: Always

Steps to Reproduce:
1. Hitting CTRL+F

Actual Results:  
Search text field doesn't get selected

Expected Results:  
Search text field gets selected
I think that perhaps we should think about how the CTRL+F search key can work. We can also use it to bring up the Advanced search ability that is mentioned in bug 118122. But until then, it could at least cause the focus to center on the Search field.
Severity: normal → minor
Status: UNCONFIRMED → NEW
Ever confirmed: true
Implementation note:
Use accel+f, not ctrl. Mac uses command F
Attached patch add key, focusSplinter Review
This patch does as described in comment #1, focusing the searchbox on accel+F
Assignee: nobody → jminta
Status: NEW → ASSIGNED
Attachment #235445 - Flags: second-review?(mvl)
Attachment #235445 - Flags: first-review?(mattwillis)
Comment on attachment 235445 [details] [diff] [review]
add key, focus

> +<!ENTITY calendar.find.key                        "F">
Just a style nit here.
I've come to the realization that trying to align things never ends up working well, and if you want to keep things aligned, you end up hosing cvs blame a lot.
As a result, I've been simply putting 2 spaces between the entity name and the double-quote. Then you won't have to worry about lining things up if you later make a long entity name.
Doing this here is obviously up to you.

r1=lilmatt
Attachment #235445 - Flags: first-review?(mattwillis) → first-review+
Comment on attachment 235445 [details] [diff] [review]
add key, focus

r2=mvl
Attachment #235445 - Flags: second-review?(mvl) → second-review+
Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
verified with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060929 Sunbird/0.3
Status: RESOLVED → VERIFIED
Whiteboard: [litmus testcase wanted]
Litmus testcase 2641 created
Whiteboard: [litmus testcase wanted]
You need to log in before you can comment on or make changes to this bug.