If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

nsUrlClassifierDBService::CloseDb isn't quite right

RESOLVED FIXED

Status

()

Toolkit
Safe Browsing
--
minor
RESOLVED FIXED
11 years ago
3 years ago

People

(Reporter: Adam Guthrie, Assigned: Adam Guthrie)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

1.07 KB, patch
Tony Chang (Google)
: review+
Darin Fisher
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

11 years ago
See bug 338677. Looks like this is right on branch: http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/components/url-classifier/src/nsUrlClassifierDBService.cpp&rev=1.1.2.11&mark=515-518#508
(Assignee)

Comment 1

11 years ago
Created attachment 233041 [details] [diff] [review]
patch

I just copied what branch is doing, which seems to be correct.
Assignee: nobody → ispiked
Status: NEW → ASSIGNED
Attachment #233041 - Flags: superreview?(darin)
Attachment #233041 - Flags: review?
(Assignee)

Updated

11 years ago
Attachment #233041 - Flags: review? → review?(tony)

Comment 2

11 years ago
Comment on attachment 233041 [details] [diff] [review]
patch

Thanks for sync'ing up trunk.
Attachment #233041 - Flags: review?(tony) → review+

Updated

11 years ago
Attachment #233041 - Flags: superreview?(darin) → superreview+
(Assignee)

Updated

11 years ago
Whiteboard: [checkin needed]

Comment 3

11 years ago
on trunk
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Component: Phishing Protection → Phishing Protection
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.