348173 - Menu popups missing a border in non-flat style

Status: RESOLVED WORKSFORME

(SeaMonkey :: Themes, defect)

Description

[Simon Bünzli]

In the spirit of 313388, menu popups should be modified in the following way to better match Windows Classic appearance. Note the third color instead of the 1px padding which makes a minor difference when Menu (background) != ThreeDFace.

border: 3px solid;
-moz-border-top-colors: ThreeDLightShadow ThreeDHighlight ThreeDFace;
-moz-border-right-colors: ThreeDDarkShadow ThreeDShadow ThreeDFace;
-moz-border-bottom-colors: ThreeDDarkShadow ThreeDShadow ThreeDFace;
-moz-border-left-colors: ThreeDLightShadow ThreeDHighlight ThreeDFace;
padding: 0px;

Comment 1

[Simon Bünzli]

Attachment: screenshot (WinXP Classic)

Comment 2

[James Ross]

Attachment: Use 3D-face colour for "padding"

Simon, well caught with this bug. :)

Comment 3

[Simon Bünzli]

Comment on attachment 233463 [details] [diff] [review]
Use 3D-face colour for "padding"

I somehow doubt that Kevin is going to have a look at this patch anytime soon...

Comment 4

[Asaf Romano (gone)]

Comment on attachment 233463 [details] [diff] [review]
Use 3D-face colour for "padding"

ask beltzner for ui-r before checkin.

Comment 5

[Simon Bünzli]

Comment on attachment 233463 [details] [diff] [review]
Use 3D-face colour for "padding"

Mike: See attachment 233054 [details] for a comparison of what we've got and what it should look like with this patch.

Asking for sr since there's no ui-r in this component.

Comment 6

[Simon Bünzli]

Mike: This is another case which should be quite obvious. Any chance you can spare five minutes on it?

Comment 7

[Simon Bünzli]

This bug's been fixed with the check-in of bug 337771 -> WORKSFORME.