Closed Bug 348173 Opened 16 years ago Closed 15 years ago

Menu popups missing a border in non-flat style

Categories

(SeaMonkey :: Themes, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: zeniko, Unassigned)

References

Details

Attachments

(2 files)

In the spirit of 313388, menu popups should be modified in the following way to better match Windows Classic appearance. Note the third color instead of the 1px padding which makes a minor difference when Menu (background) != ThreeDFace.

border: 3px solid;
-moz-border-top-colors: ThreeDLightShadow ThreeDHighlight ThreeDFace;
-moz-border-right-colors: ThreeDDarkShadow ThreeDShadow ThreeDFace;
-moz-border-bottom-colors: ThreeDDarkShadow ThreeDShadow ThreeDFace;
-moz-border-left-colors: ThreeDLightShadow ThreeDHighlight ThreeDFace;
padding: 0px;
Assignee: nobody → silver
Status: NEW → ASSIGNED
Simon, well caught with this bug. :)
Attachment #233463 - Flags: review?(kevin)
Blocks: 313388
No longer depends on: 313388
Assignee: silver → nobody
Status: ASSIGNED → NEW
Comment on attachment 233463 [details] [diff] [review]
Use 3D-face colour for "padding"

I somehow doubt that Kevin is going to have a look at this patch anytime soon...
Attachment #233463 - Flags: review?(kevin) → review?(mano)
Comment on attachment 233463 [details] [diff] [review]
Use 3D-face colour for "padding"

ask beltzner for ui-r before checkin.
Attachment #233463 - Flags: review?(mano) → review+
Comment on attachment 233463 [details] [diff] [review]
Use 3D-face colour for "padding"

Mike: See attachment 233054 [details] for a comparison of what we've got and what it should look like with this patch.

Asking for sr since there's no ui-r in this component.
Attachment #233463 - Flags: superreview?(beltzner)
Mike: This is another case which should be quite obvious. Any chance you can spare five minutes on it?
Keywords: uiwanted
Attachment #233463 - Flags: superreview?(beltzner)
This bug's been fixed with the check-in of bug 337771 -> WORKSFORME.
Status: NEW → RESOLVED
Closed: 15 years ago
Keywords: uiwanted
Resolution: --- → WORKSFORME
Product: Core → SeaMonkey
You need to log in before you can comment on or make changes to this bug.