Join Channel dialog creating messages in client

RESOLVED FIXED

Status

Other Applications
ChatZilla
--
minor
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: James Ross, Assigned: Gijs)

Tracking

({regression})

Trunk
regression

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [cz-0.9.78])

Attachments

(1 attachment, 1 obsolete attachment)

2.66 KB, patch
James Ross
: review+
Details | Diff | Splinter Review
(Reporter)

Description

11 years ago
When the Join Channel dialog opens and fetches the list of channels, or the user hits Refresh, the following get displayed in the main ChatZilla window:

[INFO]	List reply will appear on the “moznet” view.

===	Channel Users Name
===	End of /LIST
[INFO]	Displayed 0 of 140 channels.

Obviously, the 140 channel items themselves got saved to the file, but we need to supress all the other messages when saving to a file, including any errors (though they should be placed into the _list object).
(Reporter)

Updated

11 years ago
Version: unspecified → Trunk
(Assignee)

Comment 1

11 years ago
Created attachment 249260 [details] [diff] [review]
Patch

There was an unload handler, except it was never attached to the window. That and checking for the dialog everywhere works. AFAICT, saveTo isn't really used anymore? Maybe I missed something though...
Assignee: rginda → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Attachment #249260 - Flags: review?(silver)
(Reporter)

Comment 2

11 years ago
Comment on attachment 249260 [details] [diff] [review]
Patch

The checks for "saveTo" should be changed to "file" (see the setup code in CIRCNetwork.prototype.list).
Attachment #249260 - Flags: review?(silver) → review-
(Assignee)

Comment 3

11 years ago
Created attachment 249477 [details] [diff] [review]
Patch

Sure thing! :-)
Attachment #249260 - Attachment is obsolete: true
Attachment #249477 - Flags: review?(silver)
(Reporter)

Updated

11 years ago
Attachment #249477 - Flags: review?(silver) → review+
(Assignee)

Comment 4

11 years ago
Checking in mozilla/extensions/irc/xul/content/channels.xul;
/cvsroot/mozilla/extensions/irc/xul/content/channels.xul,v  <--  channels.xul
new revision: 1.2; previous revision: 1.1
done
Checking in mozilla/extensions/irc/xul/content/handlers.js;
/cvsroot/mozilla/extensions/irc/xul/content/handlers.js,v  <--  handlers.js
new revision: 1.143; previous revision: 1.142
done
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Whiteboard: [cz-0.9.78]
You need to log in before you can comment on or make changes to this bug.