Closed
Bug 348215
Opened 19 years ago
Closed 19 years ago
Join Channel dialog creating messages in client
Categories
(Other Applications Graveyard :: ChatZilla, defect)
Other Applications Graveyard
ChatZilla
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bugzilla-mozilla-20000923, Assigned: Gijs)
Details
(Keywords: regression, Whiteboard: [cz-0.9.78])
Attachments
(1 file, 1 obsolete file)
|
2.66 KB,
patch
|
bugzilla-mozilla-20000923
:
review+
|
Details | Diff | Splinter Review |
When the Join Channel dialog opens and fetches the list of channels, or the user hits Refresh, the following get displayed in the main ChatZilla window:
[INFO] List reply will appear on the “moznet” view.
=== Channel Users Name
=== End of /LIST
[INFO] Displayed 0 of 140 channels.
Obviously, the 140 channel items themselves got saved to the file, but we need to supress all the other messages when saving to a file, including any errors (though they should be placed into the _list object).
|
Reporter | |
Updated•19 years ago
|
Version: unspecified → Trunk
|
Assignee | |
Comment 1•19 years ago
|
||
There was an unload handler, except it was never attached to the window. That and checking for the dialog everywhere works. AFAICT, saveTo isn't really used anymore? Maybe I missed something though...
Assignee: rginda → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Attachment #249260 -
Flags: review?(silver)
|
|
Reporter | |
Comment 2•19 years ago
|
||
Comment on attachment 249260 [details] [diff] [review]
Patch
The checks for "saveTo" should be changed to "file" (see the setup code in CIRCNetwork.prototype.list).
Attachment #249260 -
Flags: review?(silver) → review-
|
|
Assignee | |
Comment 3•19 years ago
|
||
Sure thing! :-)
Attachment #249260 -
Attachment is obsolete: true
Attachment #249477 -
Flags: review?(silver)
|
|
Reporter | |
Updated•19 years ago
|
Attachment #249477 -
Flags: review?(silver) → review+
|
|
Assignee | |
Comment 4•19 years ago
|
||
Checking in mozilla/extensions/irc/xul/content/channels.xul;
/cvsroot/mozilla/extensions/irc/xul/content/channels.xul,v <-- channels.xul
new revision: 1.2; previous revision: 1.1
done
Checking in mozilla/extensions/irc/xul/content/handlers.js;
/cvsroot/mozilla/extensions/irc/xul/content/handlers.js,v <-- handlers.js
new revision: 1.143; previous revision: 1.142
done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: [cz-0.9.78]
|
||
Updated•2 months ago
|
Product: Other Applications → Other Applications Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•