348257 - Add-ons window additional screen reader issues

Status: RESOLVED FIXED

(Firefox :: Disability Access, defect)

Description

[Wayne DeAngelo]

Steps to reproduce:

- Run Firefox 2.0a2 nightly build 20060810 and Microsoft Inspect32 (or WindowEyes 5.5).
- Select Tools > Add-ons.  Extensions pane appears with first extension
selected.
- WindowEyes speaks "Add-ons" (window title), 
- Press down arrow.  Second extension is selected.
- WindowEyes speaks "Custom control". tab over to either disable and press enter.
- You will notice that WE does not speak the statement with the window "This add-on will be disabled when Bon Echo is restarted.

Comment 1

[Wayne DeAngelo]

NOTE: This reported problem is seen after installing the fix for bug 338048

Comment 2

[Aaron Leventhal]

Sounds like 2 problems. Window-Eyes should say "custom control" and it should speak the entire list item's text.

What's the accessible name/role we're exposing?

Comment 3

[Ryan Jones-Ward [:sciguyryan]]

Duplicate of bug 335645?

Comment 4

[Aaron Leventhal]

Note a dupe, and not fixed. This is the 2nd set of problems seen after bug 338048 was checked in.

Comment 5

[Mark Pilgrim (inactive)]

Attachment: get operation text out of anonymous content nestled within hbox

Everything that needs to be said is in the comments in the patch.

Comment 6

[Asaf Romano (gone)]

Comment on attachment 233904 [details] [diff] [review]
get operation text out of anonymous content nestled within hbox

>Index: toolkit/mozapps/extensions/content/extensions.xml
>===================================================================
>RCS file: /cvsroot/mozilla/toolkit/mozapps/extensions/content/extensions.xml,v
>retrieving revision 1.17.2.14
>diff -u -8 -p -r1.17.2.14 extensions.xml
>--- toolkit/mozapps/extensions/content/extensions.xml	14 Aug 2006 17:49:21 -0000	1.17.2.14
>+++ toolkit/mozapps/extensions/content/extensions.xml	16 Aug 2006 01:58:06 -0000
>@@ -173,17 +173,17 @@
>   <binding id="addon-selected" extends="chrome://mozapps/content/extensions/extensions.xml#addon-base">
>     <content>
>       <xul:hbox flex="1">
>         <xul:vbox class="addon-icon" xbl:inherits="iconURL"/>
>         <xul:vbox flex="1" class="addonTextBox">
>           <xul:hbox anonid="addonNameVersion" class="addon-name-version" xbl:inherits="name, version"/>
>           <xul:label anonid="addonDescriptionWrap" class="descriptionWrap" xbl:inherits="xbl:text=description"/>
>           <xul:vbox anonid="addonSelectedStatusMsgs" class="selectedStatusMsgs">
>-            <xul:hbox class="addon-optype attention" align="center"/>
>+            <xul:hbox anonid="addonOpType" class="addon-optype attention" align="center"/>
>             <xul:hbox flex="1" class="updateAvailableBox attention">
>               <xul:label xbl:inherits="value=updateAvailableMsg" crop="end"/>
>             </xul:hbox>
>             <xul:hbox flex="1" class="incompatibleBox attention">
>               <xul:label anonid="incompatibleLabel" crop="end"/>
>             </xul:hbox>
>             <xul:hbox flex="1" class="needsDependenciesBox attention">
>               <xul:label value="&needsDependencies.label;" crop="end"/>
>@@ -261,28 +261,53 @@
>       <field name="_descriptionWrap">
>         document.getAnonymousElementByAttribute(this, "anonid", "addonDescriptionWrap");
>       </field>
> 
>       <field name="_selectedStatusMsgs">
>         document.getAnonymousElementByAttribute(this, "anonid", "addonSelectedStatusMsgs");
>       </field>
> 
>+      <field name="_opType">
>+        document.getAnonymousElementByAttribute(this, "anonid", "addonOpType");
>+      </field>
>+
>       <property name="label" readonly="true">
>         <getter>
>           <![CDATA[
>             var labelPieces = [];
> 
>             // Add name and version
>             labelPieces.push(this._nameVersion.getAttribute("name"));
>             labelPieces.push(this._nameVersion.getAttribute("version"));
> 
>             // Add description
>             labelPieces.push(this._descriptionWrap.textContent);
> 
>+            // Add operation message (if any)
>+            // Note 1: must handle this separately from other the labels
>+            // because this message is in an anonymous content node
>+            // within an hbox which is dynamically bound to a different
>+            // "addon-needs-*" binding based on the operation type.
>+            // Note 2: must check hbox's CSS "display" property with
>+            // getComputedStyle, because XUL "hidden" and "collapsed"
>+            // attributes never change.

Just |hidden|, not collapsed (the collapsed attribute is mapped to a |visibility: hidden;| style rule, which you don't, and you shouldn't check).

>+            // Note 3: ....
>+            // &toBeDisabled.label text), but the hbox is no longer visible
>+            // because its CSS "display" property is reset to "none".

"is no longer visibile." is enough :)

>+            if (document.defaultView.getComputedStyle(this._opType, '').display != 'none') {
>+              labelPieces.push(document.getAnonymousNodes(this._opType)[0].value);
>+            }
>+

nit: ger rid of single-line braces.

r=mano otherwise.

Comment 7

[Mark Pilgrim (inactive)]

Attachment: fixed nits

Comment 8

[:Gavin Sharp [email: [e-mail]]]

mozilla/toolkit/mozapps/extensions/content/extensions.xml 	1.37

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 234029 [details] [diff] [review]
fixed nits

a=beltzner on behalf of 181drivers

Comment 10

[:Gavin Sharp [email: [e-mail]]]

mozilla/toolkit/mozapps/extensions/content/extensions.xml 	1.17.2.17

Comment 11

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381