Closed Bug 348280 Opened 18 years ago Closed 16 years ago

Various button "sizes" look bad, size to widest required and make all identical in that tab/panel

Categories

(Firefox :: Settings UI, defect)

x86
Windows XP
defect
Not set
trivial

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: BoxerBoi76, Unassigned)

References

Details

(Keywords: polish)

Attachments

(3 files)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060810 BonEcho/2.0b1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060810 BonEcho/2.0b1

Various button "sizes" look bad, size to widest required and make all identical in that tab/panel; Do the same for all tabs/panels in the new prefs dialog

Reproducible: Always

Steps to Reproduce:
1) Launch FF
2) Navigate to Tools-> Options-> Security
3) Observe the various button sizes/widths


Actual Results:  
Buttons are various sizes/widths based on the text in the button;

Expected Results:  
All buttons are sized to the widest width required;

Dialogs/panels that have buttons should all be the same width as it looks MUCH better;
Blocks: pref-reorg
Flags: blocking-firefox2?
Don't care about this anymore.
Status: UNCONFIRMED → RESOLVED
Closed: 18 years ago
Resolution: --- → INVALID
Status: RESOLVED → UNCONFIRMED
Resolution: INVALID → ---
See screenshot. There are two different factors: the real difference in size (height x width) and the optical difference in size. The latter factor is the most important.

"Tabs", "Privacy", "Security", "Advanced" match together in optical size.
"Main" matches in style but the real size is somewhat too big.

The two icons that look inconsistent are "Content" and "Feeds"
"Feeds" looks a lot bigger because the real size is bigger but also because of the optical size (it is more massive, there is less background space and the color is a lot more prominent than e.g. "Advanced").
"Content" is bigger than "Advanced" in real size but also the color saturation is too high.

I would suggest this:
"Privacy", "Security" an "Tabs" should stay the same.
"Advanced" (which has a gray metal color) should get another color, e.g. light purple or blue (this to match better with "Content" and "Feeds").
"Main" should be one or two pixels smaller.
"Content" should also be a bit smaller + less saturation in color.
"Feeds" should be one or two pixels smaller + less saturation in color (more gray factor). 
probably better to open another bug for that issue (or did you mean attachment 233215 [details] for bug 347497?) since that is quite different from the issue with button widths in options content described in comment 0 and in the previous two attachments
(In reply to comment #6)
> probably better to open another bug for that issue (or did you mean attachment
> 233215 [edit] for bug 347497?) since that is quite different from the issue with
> button widths in options content described in comment 0 and in the previous two
> attachments
> 
I thought it was the same issue but in case it is different I opened bug 348325, which can be duped if it is the same :)

(In reply to comment #7)
> I thought it was the same issue but in case it is different I opened bug
> 348325, which can be duped if it is the same :)
I'm referring to the size difference between "Exceptions" and "Show Cookies".  I believe all buttons should be the same width!  It looks more visually appealing when there is consistency.  This would be one more area where FF would align with Windows.

~B
This is something Ben Goodger has commented as well, in review meetings for the prefs window.  Perhaps not all the buttons in an entire dialog window need to be the same, but all the buttons in a section, or in a vertical column, or something like that should be the same.
not going to block on this, its trivial at best.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: blocking-firefox2? → blocking-firefox2-
Keywords: polish
Some of this can be done with judicious use of grids, while some (groupbox-spanning things, mostly) can't.  Patches accepted, but there are more important things to deal with than slightly inconsistent button sizes...
(In reply to comment #9)
> This is something Ben Goodger has commented as well, in review meetings for the
> prefs window.  Perhaps not all the buttons in an entire dialog window need to
> be the same, but all the buttons in a section, or in a vertical column, or
> something like that should be the same.

Peter,

That was what I was referring to but obviously didn't state it clearly.  :-(  All buttons in a vertical column should always be the same width.  The is the default behavior on Windows.

~B
(In reply to comment #12)
> All buttons in a vertical column should always be the same width.  The is the
> default behavior on Windows.

I doubt that. Buttons do have a minimum button width (which happens to be sufficient for all buttons in attachment 233168 [details]) but will individually grow wider if needed. The same also happens for Firefox' Options dialog.
(In reply to comment #13)
> I doubt that. Buttons do have a minimum button width (which happens to be
> sufficient for all buttons in attachment 233168 [details] [edit]) but will individually grow
> wider if needed. The same also happens for Firefox' Options dialog.

My point is that if you look in "Privacy", I'm stating that all of those buttons (those in the vertical column) should be the same width as "Show Cookies..." or in other words the minimum button width should be whatever is required for the largest button (button with the most text) and all other buttons if in a vertical column should be that width.  If this was the case then all of the buttons in "Privacy" would be the same width as "Show Cookies..." which would look much nicer.  This bug is about making that the default behavior for all buttons in a vertical column in FF.

~B
This is no longer an issue in current trunk builds!

~B
Version: unspecified → Trunk
This is no longer an issue in current trunk builds!

~B
Status: NEW → RESOLVED
Closed: 18 years ago16 years ago
Resolution: --- → FIXED
URL: N/A
Resolution: FIXED → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: