348317 - tweakers.net shows black parts/boxes

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Ger Teunis]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060810 Minefield/3.0a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060810 Minefield/3.0a1

www.tweakers.net shows some black boxes, making some content not visible.


Reproducible: Always

Steps to Reproduce:
1. Browse to www.tweakers.net
2.
3.

Actual Results:  
A tall black box is shown on the right of the page and a smaller one in one of the headers.

Expected Results:  
Correctly displayed tweakers.net page.

I think this is a regression from the latest GFX perf tweaks
(Bug #343655 or Bug #342366)

Comment 1

[Peter van der Woude [:Peter6]]

I'll check which one it was later tonight

Comment 2

[u88484]

Confirmed...even after the fix for bug 348191. When you scroll down then back up most of it disappears. And the image is a .gif also so this may be related to one of the older .gif bugs

Comment 3

[Ger Teunis]

(In reply to comment #2)
> And the image is a .gif also so this may be related
> to one of the older .gif bugs

This one is new in the last 2 nightlies, never encountered it before.
(the site is one of the biggest IT newssites in the Netherlands). 

Comment 4

[Peter van der Woude [:Peter6]]

bug 348191 caused this

Comment 5

[Peter van der Woude [:Peter6]]

a long time ago that c&P failed me
bug 343655 caused this(In reply to comment #4)
> bug 348191 caused this
> 
strike previous, poor C&P action at my end
bug 343655 caused this

Comment 6

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

343655 probably did, but I'm stumped as to why; both images are rendered correctly /sometimes/, whereas the changes in 343655 should pretty much either cause misrendering all the time or never.  A small testcase would be useful; I can't reproduce the problem with the images themselves, just with that whole page.  I'll keep looking at this.

Comment 7

[Peter van der Woude [:Peter6]]

any clue how to set up a testcase for this Martijn ?

Comment 8

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: call NewPath()

You'd think that after having made this same mistake 10x times, I'd have caught all of them by now.. grr.  This should fix this site, and also should fix a whole bunch of other random "area of page is filled with solid color" bugs that I'm surprised noone has reported today. :)

Comment 9

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Checked in.

Comment 10

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060811 Minefield/3.0a1 ID:2006081114 [cairo]

verified/fixed for the tweakers.net case

Comment 11

[Christian :Biesinger (don't email me, ping me on IRC)]

maybe it would've been better to make Fill() etc clear the path?