Closed Bug 348363 Opened 14 years ago Closed 13 years ago

[code cleanup] remove unused strings in updates.properties and updates.dtd

Categories

(Toolkit :: Application Update, defect, minor)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla1.9alpha6

People

(Reporter: moco, Assigned: philor)

References

Details

Attachments

(1 file, 1 obsolete file)

[code cleanup] remove unused strings in updates.properties and updates.dtd

this would be done after the fix for #329729 lands

here's what needs to be removed.

Index: locales/en-US/chrome/mozapps/update/updates.dtd

-<!ENTITY  updatesfound.title              "Update Available">

Index: locales/en-US/chrome/mozapps/update/updates.properties

-updateType_major=New Version
-updateType_minor=Security Update
-introType_major=A new version of %S is available:
-license404Error=The license file could not be found. Please contact the distributor.
-downloadingLicense=Downloading license text...
-downloadButton=Download & Install Now »
-downloadButton.accesskey=D
from https://bugzilla.mozilla.org/show_bug.cgi?id=329729#c72

remove:

introType_minor=An important Security Update for %S is available:
introType_major=A new version of %S is available:
also to be removed:

-IAgree=I Agree
-IAgree.accesskey=A
-IDoNotAgree=I Disagree
-IDoNotAgree.accesskey=D
sorry for the bug spam, re-assigning bugs back to default owner if I'm not working actively on them.
Assignee: sspitzer → nobody
(In reply to comment #0)
> [code cleanup] remove unused strings in updates.properties and updates.dtd
> 
> -updateType_major=New Version
> -updateType_minor=Security Update

Looks like either those two are still used by http://lxr.mozilla.org/seamonkey/source/toolkit/mozapps/update/content/history.js#68 or update history is broken.
Attached patch Fix v.1 (obsolete) — Splinter Review
Make the bad words go away.
Assignee: nobody → philringnalda
Status: NEW → ASSIGNED
Attachment #265894 - Flags: review?(gavin.sharp)
Hardware: PC → All
Version: 2.0 Branch → Trunk
Target Milestone: --- → Firefox 3 alpha6
Target Milestone: Firefox 3 alpha6 → Firefox 3 beta1
Comment on attachment 265894 [details] [diff] [review]
Fix v.1

(will be) bitrotted by bug 384985 (once I check that in).
Attachment #265894 - Attachment is obsolete: true
Attachment #265894 - Flags: review?(gavin.sharp)
Attached patch Fix v.2Splinter Review
Leftovers.
Attachment #269965 - Flags: review?(gavin.sharp)
Attachment #269965 - Flags: review?(gavin.sharp) → review+
toolkit/locales/en-US/chrome/mozapps/update/updates.properties 1.34
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: Firefox 3 beta1 → Firefox 3 alpha6
Flags: in-testsuite-
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.