348363 - [code cleanup] remove unused strings in updates.properties and updates.dtd

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[(not reading, please use [e-mail] instead)]

[code cleanup] remove unused strings in updates.properties and updates.dtd

this would be done after the fix for #329729 lands

here's what needs to be removed.

Index: locales/en-US/chrome/mozapps/update/updates.dtd

-<!ENTITY  updatesfound.title              "Update Available">

Index: locales/en-US/chrome/mozapps/update/updates.properties

-updateType_major=New Version
-updateType_minor=Security Update
-introType_major=A new version of %S is available:
-license404Error=The license file could not be found. Please contact the distributor.
-downloadingLicense=Downloading license text...
-downloadButton=Download & Install Now »
-downloadButton.accesskey=D

Comment 1

[(not reading, please use [e-mail] instead)]

from https://bugzilla.mozilla.org/show_bug.cgi?id=329729#c72

remove:

introType_minor=An important Security Update for %S is available:
introType_major=A new version of %S is available:

Comment 2

[(not reading, please use [e-mail] instead)]

also to be removed:

-IAgree=I Agree
-IAgree.accesskey=A
-IDoNotAgree=I Disagree
-IDoNotAgree.accesskey=D

Comment 3

[(not reading, please use [e-mail] instead)]

sorry for the bug spam, re-assigning bugs back to default owner if I'm not working actively on them.

Comment 4

[Phil Ringnalda (:philor)]

(In reply to comment #0)
> [code cleanup] remove unused strings in updates.properties and updates.dtd
> 
> -updateType_major=New Version
> -updateType_minor=Security Update

Looks like either those two are still used by http://lxr.mozilla.org/seamonkey/source/toolkit/mozapps/update/content/history.js#68 or update history is broken.

Comment 5

[Phil Ringnalda (:philor)]

Attachment: Fix v.1

Make the bad words go away.

Comment 6

[Phil Ringnalda (:philor)]

Comment on attachment 265894 [details] [diff] [review]
Fix v.1

(will be) bitrotted by bug 384985 (once I check that in).

Comment 7

[Phil Ringnalda (:philor)]

Attachment: Fix v.2

Leftovers.

Comment 8

[Phil Ringnalda (:philor)]

toolkit/locales/en-US/chrome/mozapps/update/updates.properties 1.34