348395 - twisty in header pane (next to email addresses) when there shouldn't be?

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[(not reading, please use [e-mail] instead)]

twisty in header pane (next to email addresses) when there shouldn't be?

let me attach a screen shot.

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: screen shot

Comment 2

[(not reading, please use [e-mail] instead)]

when I saw this, it was happening on many messages, but now, it is not happening anywhere.

could it be related to recent changes mscott and neil made for the header pane recently?

Comment 3

[(not reading, please use [e-mail] instead)]

note, I have not been able to reproduce this, but I think a legit bug is lurking...

Comment 4

[(not reading, please use [e-mail] instead)]

ok, I think I have a way to reproduce this.

1) select a message in a folder (folder A) with many addresses on the cc line (message X)
2) switch to another folder (folder A) and find a message with one or two cc'd addresses (message Y)
3) switch back to folder A, get the twisty on message X
4) switch back to folder B, the the twisty persists on message Y

Comment 5

[David :Bienvenu]

 the header pane improvements seem a likely suspect.

Comment 6

[Scott MacGregor]

Neil, it looks like I'm not the only one who gets the twisties when they shouldn't be there :)

Comment 7

[[e-mail]]

Sorry, but I can't seem to reproduce this...

* Does it only occur when switching folders?
* Do you need "remember the last selected message"?
* Do you need to expand the twisty on the message that is supposed to have it?
* Does the twisty disappear if you resize the window?
* Is there anything else I have forgotten?

Comment 8

[Nelson Bolyard (seldom reads bugmail)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060824 SeaMonkey/1.5a

I confirm seeing this in SeaMonkey trunk, every day for a few weeks now.  
It just about gave me a heart attack.  I sent a very confidential email to 
one person, and checked the email in the Sent folder to make SURE that I 
only sent it to that one person.  When I saw the twisty, I just about died.

If I click on that [+], it changes into [-] but the rest of the display
line doesn't change.  

There used to be a problem where the header pane was sometimes much taller 
than it needed to be, with many blank lines in it.  This occurred when the 
twisty showed [+], and bonking the twisty twice fixed it.  I haven't seen
that problem for a few weeks now, and I wonder if the new twisty behavior 
is a side effect of the fix for that problem.

Comment 9

[David :Bienvenu]

yes, I think it is a side-effect of that or related changes...

Comment 10

[Michael Kratz]

*** Bug 353637 has been marked as a duplicate of this bug. ***

Comment 11

[Serge Gautherie (:sgautherie)]

(SeaMonkey) bug 355662 and bug 366825 could be related to this one...

Comment 12

[Greg Colyer]

And SeaMonkey bug 369572 (probably a dupe). Seems like we need another MailNews component under Core (but I'm not the right person to report that)...

Comment 13

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

I hit this ~100% of the time at work.  I'll see if I can figure out steps to repro with a clean profile.

Comment 14

[Scott MacGregor]

Chris, have you had any luck poking at this? I've been noticing it too.

Comment 15

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Nope.  I didn't get around to trying a clean profile though.

Comment 17

[Rod Whiteley]

Perhaps part of the problem is that in mailWidgets.xml, the method clearEmailAddresses does not remove the twisty--it only changes it to +.  Adding this line seems to fix it:

this.toggleIcon.collapsed = true;

Comment 19

[Nelson Bolyard (seldom reads bugmail)]

I tried Rod's suggested fix from comment 17, and it did seem to fix this.

Comment 20

[Scott MacGregor]

Attachment: the fix

based on Rod's comment 17 and Nelson's verification of Rod's fix.

Comment 22

[[e-mail]]

Comment on attachment 265847 [details] [diff] [review]
the fix

I can't actually reproduce this bug as described. The only bug I can reproduce is that switching folders to a message that should show the twisty doesn't then display it.

The one thing I was worried about was that the twisty would not show up when it used to. That at least is not the case, so I feel I can still r+ this even though I notice no effect at all!

Comment 23

[Scott MacGregor]

fixed on the trunk. Thanks so much for the patch Rod! 

Comment 24

[Scott MacGregor]

Comment on attachment 265847 [details] [diff] [review]
the fix

nominating for tbird 2.0.0.5. This is a mailnews only fix and doesn't effect firefox.

Comment 25

[Daniel Veditz [:dveditz]]

Comment on attachment 265847 [details] [diff] [review]
the fix

approved for 1.8.1.5, a=dveditz for release-drivers

Comment 26

[Frédéric Buclin]

This bug is still visible in version 2.0.0.5pre (20070628).

Comment 27

[Carsten Book [:Tomcat]]

i still see this bug in the 2.0.0.5 Release Candidate on Windows Vista, i have the same like in seths screenshot, comment #1

Comment 28

[u279076]

This bug is still visible in 2005rc1 (2007071611) on both Windows XP SP2 and Ubuntu 7.04.  However, it is very sporadic.  Sometimes I get the twisty, sometimes I do not.  In fact, I can click on an email and see the twisty, then come back to that email later and the twisty will be gone, then come back to the email even later and the twisty will be back again.

Comment 29

[Marcia Knous [:marcia]]

I see this as well on the Intel Mac RC2, version 2.0.0.5 (20070716). My STR were simply to send an email with 2 cc's on the list. Subsequent attempts to try to reproduce with same steps did not work. And when I went back to the original message the twisty was gone.

Comment 30

[Carsten Book [:Tomcat]]

removing the fixed1.8.1.5 keyword since this is not fixed in 1.8.1.5 RC 1 Build, see comment #26 - #29

Comment 31

[rsx11m]

This problem still appears in the 2.0.0.6 (Windows/20070728) release, but different. I have a couple of e-mails with long c/c lists back-to-back in the Inbox (on IMAP server), with one having just two entries in the c/c inbetween. Walking mail to mail using the cursor keys, or directly left-clicking on the mails, the twisty shows up correctly at the first long-c/c e-mail, then disappears for the next one with a c/c list of identical length. The e-mail with a short or long c/c list shows the twisty again. Thus, the issue only seem to appear with lists of equal length. This is reproducible after restarting Thunderbird.

Also noticed occasional reappearances of the twisty in To or Cc lists which are short enough to display all addresses in a single line (less frequently than before 2.0.0.5, don't notice any reproducible pattern).