Closed Bug 348471 Opened 18 years ago Closed 16 years ago

When the session will be restored, don't show the multiple-tabs-closing warning

Categories

(Firefox :: Session Restore, defect)

Product:
Firefox
Component:
Session Restore
Version:
3.0 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: piratepenguin, Unassigned)

References

Details

(Keywords: polish, uiwanted) 

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060812 Minefield/3.0a1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060812 Minefield/3.0a1

When the session will be restored (when browser.startup.page equals '3' (restore session), and when restarting after downloading an update/extension), there is no need to show the "You are about to close multiple tabs. Are you sure you want to continue?" page when closing the main window, since the tabs will be restored on the next startup.

Reproducible: Always
I can reproduce this in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060812 Minefield/3.0a1.  Please change the Component: field probably to "Tabbed Browsing".
Component: General → Tabbed Browser
QA Contact: general → tabbed.browser
Same with "Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060825 BonEcho/2.0b2".  Requesting to block Firefox 2...
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: blocking-firefox2?
In order to match behaviour of disk cache/SSL, we do not by default cache anything for HTTPS sites, so there is value in confirming the action with the user.  I don't think this blocks, or can be ever completely fixed.
Agreed, this won't block the release. We need to carefully evaluate the behaviour here, and the safest thing to do until we've worked through the use cases is to follow the non-destructive path.
Flags: blocking-firefox2? → blocking-firefox2-
Keywords: polish, uiwanted
*** Bug 357532 has been marked as a duplicate of this bug. ***
Component: Tabbed Browser → Session Restore
QA Contact: tabbed.browser → session.restore
This should be partially fixed by the new quit dialog in bug 383760. There is still a prompt when restarting for an extension install or app update, however.
I was about to submit a new bug, but found this one already...

When "Show my windows and tabs from last time" is selected as the firefox start-up option, it would be sensible to also have multiple options for "Warn me when closing multiple tabs" - "never" and "always" as now, but add another option along the lines of "anytime except when closing".

This would get round the problem of having no warning when closing the main window with lots of open tabs expecting them to return next time only to find another firefox window (often a pop-up window) remains. This single tab window then becomes the start-up tab next time, rather than having the many tabs as expected.

An alternative to "anytime except when closing" could be based on the number of tabs being closed compared to those being left behind, maybe provide a warning only when the majority of tabs are being closed or more than x are being closed?
If this request is implemented, please do it only for explicit File->Exit command because I've accidentally closed the browser (by clicking the wrong X icon or pressing Alt+F4) too many times and want to have the confirmation box.
This was fixed by bug 428843.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Version: unspecified → 3.0 Branch
This is a shame that a choice has been taken away from users who *always* want to be warned when multiple tabs are about to be closed.
Roman: Your bug 428742 to fix the very thing your complaining about is still open. Please add all constructive contributions over there.
(In reply to comment #13)
> This is a shame that a choice has been taken away from users who *always* want
> to be warned when multiple tabs are about to be closed.

If you want to be prompted all the time, just avoid setting the "show my tabs and windows from last time" pref in the General pane under "When Firefox starts". The dialog that will appear will still give you the option of saving your session.
(In reply to comment #15)
> If you want to be prompted all the time, just avoid setting the "show my tabs
> and windows from last time" pref...

This would be a good suggestion if Firefox (and OS) never crashed or froze.


We restore sessions after crashes regardless of whether that preference is set.
Verified with Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2a1pre) Gecko/20090618 Minefield/3.6a1pre ID:20090618031329
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.