348542 - Move keyword validation out of post_bug.cgi and into Bugzilla::Bug

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, enhancement)

Description

[Max Kanat-Alexander]

This is yet another step for bug 305136. The code that validates keywords is in post_bug.cgi, and should be moved into Bugzilla::Bug.

Comment 1

[Max Kanat-Alexander]

Attachment: v1

Yet another! :-) This one depends on the CC patch, but only because of the code around it. (The patch won't apply otherwise.)

Comment 2

[Olav Vitters]

Comment on attachment 233490 [details] [diff] [review]
v1

>diff -u post_bug.cgi post_bug.cgi

>@@ -437,12 +416,12 @@
> my $sth_addkeyword = $dbh->prepare(q{
>             INSERT INTO keywords (bug_id, keywordid) VALUES (?, ?)});
> if (UserInGroup("editbugs")) {
>-    foreach my $keyword (@keywordlist) {
>+    foreach my $keyword (@keyword_ids) {
>         $sth_addkeyword->execute($id, $keyword);
>     }
>-    if (@keywordlist) {
>+    if (@keyword_ids) {
>         # Make sure that we have the correct case for the kw
>-        my $kw_ids = join(', ', @keywordlist);
>+        my $kw_ids = join(', ', @keyword_ids);
>         my $list = $dbh->selectcol_arrayref(qq{
>                                     SELECT name 
>                                       FROM keyworddefs 

Nit/extra points: Just below here it updates bugs and sets delta_ts again to $timestamp. That not needed anymore and can be removed.

r=bkor.

Comment 3

[Max Kanat-Alexander]

I didn't change the delta_ts stuff, because post_bug works in mysterious ways and I don't necessarily want to mess with things. It will all get messed with soon enough anyway, when everything gets moved into Bugzilla::Bug.

Checking in post_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/post_bug.cgi,v  <--  post_bug.cgi
new revision: 1.165; previous revision: 1.164
done
Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.139; previous revision: 1.138
done