348565 - "Icons with Text" feature misaligned

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Ryan]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1b1) Gecko/20060813 BonEcho/2.0b1
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1b1) Gecko/20060813 BonEcho/2.0b1

It appears it won't allow the space for "Icons and Text" feature.  Just "Icons" or "Text" is ok.

Reproducible: Always

Comment 1

[Ryan]

Attachment: Toolbar misalignment

Comment 2

[Ryan]

It appears it won't allow the space for "Icons and Text" feature.  Just "Icons"
or "Text" is ok.

Comment 3

[Tracy Walker [:tracy]]

this regressed between the nighty builds of 0812 and 0813

Comment 4

[:Gavin Sharp [email: [e-mail]]]

*** This bug has been marked as a duplicate of 347412 ***

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Hrm, not quite the same bug.

Comment 6

[Marek Stępień [:marcoos, inactive]]

Attachment: Similar problem on Linux

Similar problem on Linux. The Back/Forward icons are a bit misplaced and they behave strangely (clicking on the text in the button opens the submenu instead of going back/forward).

Comment 7

[Pam Greene]

Attachment: Fixes original issue (toolbar text on Mac)

The max-height removed here was added for bug 347463, but as far as I can tell it can be safely removed once the lock icon is reduced to 16x16 pixels.  Mark, please speak up if this regresses 347463 in some way I haven't tested.

Comment 8

[Pam Greene]

Attachment: 16x16-pixel lock icon Secure.png for pinstripe

This icon fits in the urlbar properly, so no max-height is needed and the toolbar can stretch appropriately when both icons and text are shown.

The other UI artifact shown in the first screenshot was fixed in bug 347400.  Mano said he's about to split the back- and forward-button polish from the second screenshot into another bug.

Comment 9

[Asaf Romano (gone)]

See bug 349079, we should land these in sync.

Comment 10

[Mike Connor [:mconnor]]

Comment on attachment 234280 [details] [diff] [review]
Fixes original issue (toolbar text on Mac)

Hmm, I didn't know max-height could constrain parent elements like that, either way thanks!  r+a=me on this branch-only patch

Comment 11

[Marek Stępień [:marcoos, inactive]]

Should I file another bug about the Linux issue?

Comment 12

[Pam Greene]

Attachment: Screenshot after patch, hovering on Forward button

Attaching this to help with other fixes.

Comment 13

[Asaf Romano (gone)]

(In reply to comment #11)
> Should I file another bug about the Linux issue?
> 

If it's still an issue (please check with a build that has the fix for bug 348565).

Comment 14

[Pam Greene]

Landing patch and new image on branch.  Marking as fixed since the back- and forward-button problems are being addressed in bug 349079.

Comment 15

[Bryan]

The same issues exists on Windows builds when comparing the main toolbar icons with the address and searchbar icons when displaying text.  The text for the main toolbar icons looks as if it's aligned along the top of the toolbar while the address bar and searchbar text is centered vertically along the toolbar.  If you have small icons enabled then this doesn't appear to be as much of an issue as all text appears centered.

BUILD: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060818 BonEcho/2.0b2 ID:2006081802

~B

Comment 16

[Pam Greene]

(In reply to comment #15)
> The same issues exists on Windows builds when comparing the main toolbar icons
> with the address and searchbar icons when displaying text.

Sorry, I don't understand what problem you're describing.  I'm looking at the 2005081803 build, and nothing looks too strange.  Since the address and searchbar icons don't show text at all in the default theme, I'm guessing you're using another theme.  Could you post a screenshot, please?

Comment 17

[Marek Stępień [:marcoos, inactive]]

Right click > Customize > Display: [ Icons and text |v]

Comment 18

[Marek Stępień [:marcoos, inactive]]

Oops, sorry, my previous comment was a mistake.