34863 - Local Harddisks not found if I tried with C: without \

Status: VERIFIED FIXED

(Core :: Networking, enhancement, P3)

Description

[famtie]

From Bugzilla Helper:
User-Agent: Mozilla/4.0 (compatible; MSIE 5.01; Windows NT 5.0)
BuildID:    2000033112

If I typed C: without \ then I will get that c: is not registered. But I typed 
C:\ it will work fine. In IE c: without \ works fine. Also Gecko must be worked 
with C: without \

Reproducible: Always
Steps to Reproduce:
1.Type C: in URL
2.It will get error: c: is not registered protocool.
3.

Actual Results:  c: is not registered protocool

Comment 1

[Sean Richardson]

Confirmed with 2000-04-06-10-M15 on WinNT. "C:\" is turned into "file:///c|/";
"c:" gets the alert already mentioned.

Not sure about this one: single letters followed by ":" could be special-cased,
but that would involve a gamble that their would never be a URI scheme 
registered that would collide. Given the widespread misuse by IE, this probably
would not be much of a gamble. IE5 turns "c:" into "C:\" and displays the
expected listing. 

Changing severity to "Enhancement" as the current behaviour is per spec.

Comment 2

[Andreas Otte]

That would be another special case for convertFileToURL in nsWebShell.cpp. 

Comment 3

[famtie]

mmm. Yes. It will added:

function ConvertFileToURL() into nsWebShell.cpp
Function ConvertLocalToURL() into nsWebShell.cpp

ConvertFileToURL():
Convert: X:--> file:///X|/. It will works fine. 


But it's not beautiful as real local IE5. It would:
 ' Computer(c:)' in URL. It would be cool. Also: It will added ConvertLocalToURL

function ConvertLocalToURL()
file:///c|/ will hidden in URL. 'Computer(c:)' will shows in URL. 

 Also: label + ('(')+ drive + (')') 

Comment 4

[Andreas Otte]

Attachment: patch to allow c: or similar in urlbar

Comment 5

[famtie]

It works fine now. I see it shows local harddisk now.
I am agree with [e-mail] 

Comment 6

[Andreas Otte]

Note: the patch is not in the tree yet. 

Comment 7

[famtie]

NObody ???

Comment 8

[Andreas Otte]

Attachment: new version of patch because the function moved to nsDocShell.cpp

Comment 9

[Andreas Otte]

fix checked in

Comment 10

[famtie]

It fix does work. But it show no files in C:

C:-> file:///c: But it show no files C:
file:///c:/ it show files C: 
Also C:-> file:///c:/

build 2000041915

Comment 11

[Andreas Otte]

I already have that in my tree, got it reviewed, will check it in over the 
weekend.

Comment 12

[Andreas Otte]

fix checked in.

Comment 13

[famtie]

Have you see listing of file:///c: after c:?
By Windows 2000 is my storage used NTFS5.
Which build are you using?

Comment 14

[Andreas Otte]

Should be fixed with the patch just checked in.

Comment 15

[Stephen Walker]

marking verified using build 2000051220

Comment 16

[Sean Richardson]

Adding dependency; depends on bug 42342, "[regression} Text before ':' in URL is 
interpreted as protocol", FIX checked in. This bug is about one of the cases
that FIX should fix.

Testing with the 2000-06-20-08-M17 nightly binary, this bug did regress, but
I'll wait for a day before reopening, as it may well be working again by then.

Comment 17

[famtie]

It changed error-message: " is not registered protocol or invalid drive" if 
(x:) is not found
I will this problems wwith 42342 checked. It will stayed :
C: or C:\ will works to local harddiscs  

Comment 18

[Sean Richardson]

Testing with the 20000622...-M17 nightly binary on WinNT, "c:", "c:\", and
"c:/" all result in display of the same directory listing as "file:///c:/".

Marking FIXED, as the fix for bug 42342 *must* be responsible for this working
again.

Comment 19

[Andreas Otte]

You can bet it is responsible ... ;)

Comment 20

[famtie]

GREAT WORK! 

Comment 21

[famtie]

It is now verified