348656 - "Error: invalid quantifier" with microsummary generator installed

Status: RESOLVED INVALID

(Firefox Graveyard :: Microsummaries, defect)

Description

[Adam Guthrie]

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1b1) Gecko/20060814 BonEcho/2.0b1

I think this error is coming from my test-3.html microsummary generator. I have the generator in the microsummary-generators/ folder, but I don't have any bookmarks that use the microsummary.

http://people.mozilla.com/~aguthrie/testcases/microsummaries/test-3-generator.xml

The error is:
Error: invalid quantifier *.\/test-3\.html
Source File: file:///Applications/BonEcho.app/Contents/MacOS/components/nsMicrosummaryService.js
Line: 1165

The line is: |var urlRegexp = node.textContent.replace(/^\s+|\s+$/g, "");|.

See also bug 330796.

Comment 1

[Adam Guthrie]

Attachment: error-causing generator

Now that I look at it, the generator I linked to in comment 0 is not the one that's causing the errors. Here is the one (from my profile folder) that's the culprit.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

The line that actually generates the error is the next one:

        this._rules.push({ type: node.nodeName, regexp: new RegExp(urlRegexp) });

You can reproduce by typing the following into the error console:

        new RegExp("*.\/test-3\.html")

JavaScript is correctly reporting an invalid quantifier (although it reports it poorly per bug 330796), as the quantifier "*" appears in the regular expression before any character it might quantify.  I think you meant to write ".*" (period first) instead of "*." (asterisk first).

Marking this bug invalid, as this result is intentional, but perhaps we should do something other than fail to load the generator if one of its regular expressions is invalid (but that could get tricky given that the expressions are part of a cascade that determines the applicable pages; they don't make perfect sense independently of each other).