brand.dtd is not a well-formed DTD file because of an #expand macro

RESOLVED FIXED in Thunderbird2.0

Status

Thunderbird
General
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: RickieES aka Ricardo Palomares, Assigned: Scott MacGregor)

Tracking

({fixed1.8.1})

Thunderbird2.0
x86
All
fixed1.8.1

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

12 years ago
Line #1 of mozilla1.8/source/other-licenses/branding/thunderbird/locales/en-US/brand.dtd

is

#expand <!ENTITY  lang.version          "__MOZILLA_LOCALE_VERSION__">

which I don't think is valid syntax in a DTD file. Maybe it is a preprocessor instruction? Perhaps it should be SGML-commented so the file remains a valid DTD file.

Being a non-valid DTD file affects L10n tools like MozillaTranslator, which uses a SAX Parser to load DTD files.

The problem also affects trunk; however, I haven't found the same construction in Firefox or Thunderbird equivalent files.
Summary: brand.dtd is not a well-formed DTD file because a .properties-like comment → brand.dtd is not a well-formed DTD file because of an #expand macro
As I wrote in .l10n, the lang.version entity doesn't seem to be used outside the
/extensions/content-packs/resources/content/pref-contentpacks.xul
file, which is doesn't use Thunderbird's dtd and is only used by SeaMonkey.

It should be safe to remove the whole lang.version entity from brand.dtd.
Created attachment 233765 [details] [diff] [review]
Remove lang.version from brand.dtd

This patch removes the lang.version entity from both brand.dtd's used by Thunderbird.
Attachment #233765 - Flags: review?
Attachment #233765 - Flags: review? → review?(mscott)
(Assignee)

Comment 3

12 years ago
Comment on attachment 233765 [details] [diff] [review]
Remove lang.version from brand.dtd

benjamin might remember if there's a reason for us to define lang.version here.
Attachment #233765 - Flags: superreview?(benjamin)
Attachment #233765 - Flags: review?(mscott)
Attachment #233765 - Flags: review+

Comment 4

12 years ago
Comment on attachment 233765 [details] [diff] [review]
Remove lang.version from brand.dtd

No, that's a leftover from the seamonkey chrome registry I hope.
Attachment #233765 - Flags: superreview?(benjamin) → superreview+
(Assignee)

Comment 5

12 years ago
Marek, I landed this patch on the trunk and the branch for you. Thanks again for the fix!
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.