348662 - incoming filters for rss feeds broken

Status: VERIFIED FIXED

(MailNews Core :: Feed Reader, defect)

Description

[David :Bienvenu]

I think I broke incoming filters for rss feeds by accidentally checking in a change to nsMsgLocalMailFolder::AddMessage - basically, that routine, to be useful for extensions, shouldn't assume it should run message filters. So I changed it to check if we're getting new messages before applying filters. But I didn't check in the corresponding change to FeedItem.js, which is to set gettingNewMessages. Fix upcoming.

Comment 1

[David :Bienvenu]

Attachment: proposed fix

Comment 2

[David :Bienvenu]

Attachment: fix imap move/copy filter actions

while testing this, I found out that rss filters that move/copy to an imap folder weren't firing their actions. This fixes that by triggering the firing of coalesced imap move/copy actions (which will be just one move/copy). 

Ideally, we'd be waiting for all the downloads for the feed to be done before firing the move/copies, but that will require some tweaks to the way newsblog stores messages, and some tweaks to nsMsgLocalMailFolder::AddMessage - currently newsblog calls it for every message, but there's no indication that we're starting or finishing message retrieval for a feed, so there's no way for nsMsgLocalMailFolder::AddMessage to cache the mailbox parser and batch the move/copies.

Comment 3

[David :Bienvenu]

fixed trunk and branch - now you can setup filters to store your feeds on imap folders...

Comment 4

[Mike Cowperthwaite]

I noticed this had been broken, and it's definitely fixed with TB 3a1-0816, Win2K.

Maybe if you get a chance, you could look at bug 264382.