348689 - Keep dialog message inside resources/content instead its generating in c++

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[alexander :surkov (:asurkov)]

I guess we should keep dialog message inside resources/content instead its generating in c++. The follow up changes will be easier for message dialog and the approach is more vivid.

Comment 1

[alexander :surkov (:asurkov)]

Attachment: first try

Comment 2

[Doron Rosenberg (IBM)]

Comment on attachment 234666 [details] [diff] [review]
first try

>+    char* b64 =
>+      PL_Base64Encode(NS_ConvertUTF16toUTF8(docString).get(), 0, nsnull);
>+    if (!b64)
>+      return NS_ERROR_FAILURE;
>+
>+    nsCAutoString b64String;
>+    b64String.AppendLiteral("data:application/vnd.mozilla.xul+xml;base64,");
>+    b64String.Append(b64);
>+    PR_Free(b64);
>+
>+    CopyUTF8toUTF16(b64String, messageURL);
>  

You really need this?  No other way to load a url?

Comment 3

[alexander :surkov (:asurkov)]

Attachment: patch

I added background color for html document to approximate look of message to dialog.

Comment 4

[alexander :surkov (:asurkov)]

Attachment: patch2

Sorry, I forgot to add new file.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 235938 [details] [diff] [review]
patch2


>     NS_ENSURE_SUCCESS(rv, rv);
>+    htmlEl->SetAttribute(NS_LITERAL_STRING("style"),
>+                       NS_LITERAL_STRING("background-color: -moz-Dialog;"));

Missing 2 spaces.
Otherwise looks good. r=me

Comment 6

[alexander :surkov (:asurkov)]

checked in by smaug for me.

Comment 7

[aaronr]

checked into 1.8.0 branch on 2006/09/21

Comment 8

[aaronr]

checked into 1.8 branch on 2006/11/21