348735 - Support building js jshell with gcov

Status: RESOLVED INVALID

(Core :: JavaScript Engine, defect)

Description

[Bob Clary [:bc] (inactive)]

building the js shell on linux with gcc fails when compiling jscpucfg since it not built with CFLAGS or LDFLAGS.

Comment 1

[Bob Clary [:bc] (inactive)]

Attachment: patch

add CFLAGS and LDFLAGS to jscpucfg's rule.

Comment 2

[Bob Clary [:bc] (inactive)]

Checking in Makefile.ref;
/cvsroot/mozilla/js/src/Makefile.ref,v  <--  Makefile.ref
new revision: 3.42; previous revision: 3.41

Comment 3

[Brendan Eich [:brendan]]

jscpucfg is a build-host helper, it needs HOST_CFLAGS and HOST_LDFLAGS.  You do not want to measure its code coverage.  Cc'ing build gurus who can correct me if I'm wrong.

/be

Comment 4

[Bob Clary [:bc] (inactive)]

I don't know what I was smoking this weekend, but I can no longer reproduce the problem I was having. set XCFLAGS=--coverage and js shell builds fine for me on the trunk without any change to Makefile.ref. This bug is really invalid.

Comment 5

[Bob Clary [:bc] (inactive)]

(In reply to comment #2)
> Checking in Makefile.ref;
> /cvsroot/mozilla/js/src/Makefile.ref,v  <--  Makefile.ref
> new revision: 3.42; previous revision: 3.41
> 

This patch was BS and should not have been committed. 

Comment 6

[Bob Clary [:bc] (inactive)]

Attachment: revert patch

Checking in Makefile.ref;
/cvsroot/mozilla/js/src/Makefile.ref,v  <--  Makefile.ref
new revision: 3.43; previous revision: 3.42