Support building js jshell with gcov

RESOLVED INVALID

Status

()

RESOLVED INVALID
12 years ago
12 years ago

People

(Reporter: bc, Unassigned)

Tracking

Trunk
x86
Linux
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments)

(Reporter)

Description

12 years ago
building the js shell on linux with gcc fails when compiling jscpucfg since it not built with CFLAGS or LDFLAGS.
(Reporter)

Comment 1

12 years ago
Created attachment 233792 [details] [diff] [review]
patch

add CFLAGS and LDFLAGS to jscpucfg's rule.
Attachment #233792 - Flags: review?(mrbkap)
Attachment #233792 - Flags: review?(mrbkap) → review+
(Reporter)

Comment 2

12 years ago
Checking in Makefile.ref;
/cvsroot/mozilla/js/src/Makefile.ref,v  <--  Makefile.ref
new revision: 3.42; previous revision: 3.41
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
(Reporter)

Updated

12 years ago
Blocks: 348744
jscpucfg is a build-host helper, it needs HOST_CFLAGS and HOST_LDFLAGS.  You do not want to measure its code coverage.  Cc'ing build gurus who can correct me if I'm wrong.

/be
(Reporter)

Comment 4

12 years ago
I don't know what I was smoking this weekend, but I can no longer reproduce the problem I was having. set XCFLAGS=--coverage and js shell builds fine for me on the trunk without any change to Makefile.ref. This bug is really invalid.
(Reporter)

Updated

12 years ago
Flags: in-testsuite-
(Reporter)

Comment 5

12 years ago
(In reply to comment #2)
> Checking in Makefile.ref;
> /cvsroot/mozilla/js/src/Makefile.ref,v  <--  Makefile.ref
> new revision: 3.42; previous revision: 3.41
> 

This patch was BS and should not have been committed. 
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Reporter)

Comment 6

12 years ago
Created attachment 235178 [details] [diff] [review]
revert patch

Checking in Makefile.ref;
/cvsroot/mozilla/js/src/Makefile.ref,v  <--  Makefile.ref
new revision: 3.43; previous revision: 3.42
(Reporter)

Updated

12 years ago
Status: REOPENED → RESOLVED
Last Resolved: 12 years ago12 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.