348814 - Friends & Contributors link is not clickable until scroll starts

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[jeff monroe]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060815 BonEcho/2.0b1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060815 BonEcho/2.0b1

Spawning from bug 345537, comment #18.

On 1280 x 1024, the new Friends & Contributors link is not clickable until the credits start scrolling.

Reproducible: Always

Steps to Reproduce:
1. Open Help-->About
2. Click Credits
3. See the Friends & Contributors links
Actual Results:  
Notice you can't click the Friends & Contributors links until the page starts scrolling.

Expected Results:  
Should be able to click the links instantly.

Comment 1

[Reed Loden [:reed]]

Confirmed (I was standing behind the reporter at the time). It was a brand-new profile (as I was installing Bon Echo for him).

Comment 2

[jeff monroe]

Attachment: friends and contributors link cut-off

this shows  issue  with the friends and contributors link being cutoff.

Comment 3

[Asa Dotzler [:asa]]

*** Bug 349593 has been marked as a duplicate of this bug. ***

Comment 4

[Reed Loden [:reed]]

mwu: Can you take a look at this? Asa just confirmed it.

Comment 5

[Michael Wu [:mwu]]

Attachment: Enforce a minimum height for about dialog

This patch enforces a minimum height for the about dialog so the links aren't likely to be obscured. The links are likely to be obscured with a dpi of 75 without this patch. (layout.css.dpi)

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 235355 [details] [diff] [review]
Enforce a minimum height for about dialog

I don't see why this would get us in trouble anywhere else, but are we sure that height is enough to capture localized strings as well? Do we want to, at the same time, also maybe bring up the lines a little to keep them away from the bottom of the dialog?

Comment 7

[Michael Wu [:mwu]]

Attachment: About dialog on windows after patch

Hm, the extra space above the useragent doesn't look too good..

Comment 8

[Michael Wu [:mwu]]

Attachment: Remove redundancy

This cleans up the xul a bit and prevents the useragent box from being pegged to the bottom of the screen - the only thing that makes a minimum height look ugly.

Comment 9

[Michael Wu [:mwu]]

Checking in browser/base/content/aboutDialog.css;
/cvsroot/mozilla/browser/base/content/aboutDialog.css,v  <--  aboutDialog.css
new revision: 1.6; previous revision: 1.5
done
Checking in browser/base/content/aboutDialog.xul;
/cvsroot/mozilla/browser/base/content/aboutDialog.xul,v  <--  aboutDialog.xul
new revision: 1.27; previous revision: 1.26
done

Comment 10

[Mike Connor [:mconnor]]

Comment on attachment 235811 [details] [diff] [review]
Remove redundancy

a=mconnor on behalf of drivers for 1.8 branch checkin

Comment 11

[Christian :Biesinger (don't email me, ping me on IRC)]

MOZILLA_1_8_BRANCH:

Checking in browser/base/content/aboutDialog.css;
/cvsroot/mozilla/browser/base/content/aboutDialog.css,v  <--  aboutDialog.css
new revision: 1.2.8.3; previous revision: 1.2.8.2
done
Checking in browser/base/content/aboutDialog.xul;
/cvsroot/mozilla/browser/base/content/aboutDialog.xul,v  <--  aboutDialog.xul
new revision: 1.23.4.10; previous revision: 1.23.4.9
done

Comment 12

[Nick Thomas [:nthomas] (UTC+12)]

I was seeing this problem on Linux with the 20060905 branch build - Friends & Contributors links needed to scroll up to about quarter height of the dialog to be clickable. This corresponds to being out of the faded region, but the position is hit and miss because it's hard to hit a moving target.

This changed in the 20060906 build (which has the patch from this bug) - the fade is now missing but I can't get any response from the link until it is moving.

Same bug/different one ?

Comment 13

[Reed Loden [:reed]]

People are still complaining of this issue. See http://screwedbydesign.com/images/about.png for a screenshot of the issue on Ryan's machine (where he cannot click the links until it scrolls). Supposedly, the gradient extends that far to cover the links, which is not fun at all. :(

<@mwu> sure, but I don't know if we want to shorten the gradient or make the minimum height bigger or some combo of both

Comment 14

[Michael Wu [:mwu]]

Attachment: Smaller footer image without useless invisible 8px at top

This is identical to the original footer gradient, except there isn't that extra 8px of invisible stuff at the top. Hopefully this extra 8px is enough..

Comment 15

[Mike Connor [:mconnor]]

Comment on attachment 237197 [details]
Smaller footer image without useless invisible 8px at top

r=me, please ask some affected people to test with this patch before requesting branch approval.

Comment 16

[Michael Wu [:mwu]]

Trunk:
Checking in browser/base/branding/aboutFooter.png;
/cvsroot/mozilla/browser/base/branding/aboutFooter.png,v  <--  aboutFooter.png
new revision: 1.2; previous revision: 1.1
done

Comment 17

[Nick Thomas [:nthomas] (UTC+12)]

I tested two linux builds on the trunk:
  * hourly after the patch landed (FTP timestamp 08-Sep-2006 00:10 PDT)
  * 20060907 nightly 

In the hourly I can click on the Friends/Contributor links immediately, so the fix works. The nightly is a consistency check - I saw the same problem as observed on the branch.

Comment 18

[Michael Wu [:mwu]]

Comment on attachment 237197 [details]
Smaller footer image without useless invisible 8px at top

Fix has been verified by two people.

Comment 19

[Mike Connor [:mconnor]]

Comment on attachment 237197 [details]
Smaller footer image without useless invisible 8px at top

a=mconnor on behalf of drivers for 1.8 branch checkin

Comment 20

[Michael Wu [:mwu]]

Branch:
Checking in browser/base/branding/aboutFooter.png;
/cvsroot/mozilla/browser/base/branding/aboutFooter.png,v  <--  aboutFooter.png
new revision: 1.1.8.1; previous revision: 1.1
done