348831 - Approved: Additional search engine for Turkish Firefox 2

Status: RESOLVED FIXED

(Mozilla Localizations :: tr / Turkish, defect)

Description

[Ahmet Serkan Tıratacı]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; tr; rv:1.8.1b1) Gecko/20060815 BonEcho/2.0b1
Build Identifier: 

We'd like to have one additional search engine for Turkish Firefox 2. This is TDK (Turkish Language Association) dictionary search engine [1], which is also used for Firefox 1.5.0.x releases [2] [3].

[1] http://lxr.mozilla.org/l10n-mozilla1.8/source/tr/browser/searchplugins/
[2] http://lxr.mozilla.org/l10n-mozilla1.8.0/source/tr/browser/searchplugins/
[3] https://bugzilla.mozilla.org/show_bug.cgi?id=314566#c0

Reproducible: Always

Comment 1

[Ahmet Serkan Tıratacı]

This tr-tdk.xml is included in Firefox 2 nightlies, it's name is in list.txt, but it's not shown as a default search engine. Is this because it's not approved yet?

Will I have to do anything extra for approvals I asked in this bug and bug 348201?

Comment 2

[chris hofmann]

mic, can you have a look?

Comment 3

[Axel Hecht [:Pike]]

There is an unbound prefix error in tr-tdk.xml.

Comment 4

[Ahmet Serkan Tıratacı]

(In reply to comment #3)
> There is an unbound prefix error in tr-tdk.xml.
> 

Can you guide us to fix this?

Comment 5

[Marek Stępień [:marcoos, inactive]]

You're using the "os:" prefix without declaring it using "xmlns:os". So this is why you get the error.

http://lxr.mozilla.org/l10n-mozilla1.8/source/tr/browser/searchplugins/tr-tdk.xml#2

Just get rid of all the "os:" and it should be ok.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

This won't block the release unless Mic or Chofmann nominates it.

Comment 7

[Mic Berman]

Hey all,
BD has reviewed and we are good to go for FF2
Ahmet - can you please get me a contact name and terms of service web page for the service. We'd like to make sure they are aware that we ship with their service as a plug-in and get any feedback for how things are working.
Thanks
Mic

Comment 8

[chris hofmann]

need to get this landed today or tomorrow if it going to make firefox2.  is the patch ready to land?

Comment 9

[Ahmet Serkan Tıratacı]

Mic: There's unfortunately no terms of service at TDK web site. However, president of TDK speaks to media very often and encourages people to use its online dictionary that is indeed the first reference as a Turkish dictionary provided by TDK, state's official institution of Turkish language. I've just emailed them to ensure that they are aware of the use of their search engine and told that Mozilla might want feedback.

Chris: It's just been checked in.

http://bonsai-l10n.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/l10n&subdir=l10n/tr/browser/searchplugins&command=DIFF_FRAMESET&root=/l10n&file=tr-tdk.xml&rev1=1.1.2.2&rev2=1.1.2.3

Comment 10

[Mic Berman]

Ahmet,
thanks - do you have a specific contact you emailed so i can add to our internal list of international contacts, if not, when you do please just add to this bug and i'll put in our list
thanks!
mic

Comment 11

[Ahmet Serkan Tıratacı]

Mic, I emailed the department concerned via bim at tdk.org.tr. (The "bim" stands for "bilgi iþlem merkezi" -data processing desk- the department responsible for the web site.) No specific person yet, as I haven't been replied yet. I'll post the name as soon as I'm replied.

I wish we had more time to find a contact. That would increase the chance to be replied, as such institutions get many inquiries every day. Anyway, let's wait and see.

Comment 12

[Axel Hecht [:Pike]]

Ahmet, as this is a 1.5 compat thing, there is no reason to panic or rush.
We'd like to get the contact information soon, but we're not going to make a stop-ship decision based on whether tdk came back to us yet or not.

Comment 13

[Ahmet Serkan Tıratacı]

OK. Thanks for the clarification.

Comment 14

[Mic Berman]

exactly, thanks Axel for clarification and sorry to Ahmet for added stress.
I am closing this bug and Ahmet when you do hear back from someone there please send me the email you recieve.
thanks very much
mic