XULRunner Universal build fails trying to build JavaXPCOM

RESOLVED FIXED

Status

defect
RESOLVED FIXED
13 years ago
5 years ago

People

(Reporter: jhpedemonte, Assigned: jhpedemonte)

Tracking

({fixed1.8.0.7, fixed1.8.1})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

The XULRunner/Mac trunk build is set to build a universal version of XULRunner.  It is failing when trying to run GenerateJavaInterfaces program.  It is trying to run the Intel GenerateJavaInterfaces program on a PPC machine.

I think I need to treat GenerateJavaInterfaces the same way that xpidl is treated when cross compiling.
Actually, it's not as easy as doing what we do for xpidl.  Xpidl is a standalone program that only depends on libxpt (which is also handled differently when cross compiling).  GenerateJavaInterfaces links against the XPCOM and NSPR libs, none of which are built as HOST_LIBS.

Since this problem won't be an issue once we switch to using xpidl for generating Java interfaces (bug 333618), I'm wondering if it wouldn't be best to just put a quick and dirty hack in GenerateJavaInterfaces' Makefile, in order to get this tinderbox building.
Since the generated files aren't arch-specific, for UB builds we can safely just skip the GenerateJavaInterfaces step during the cross-compile phase.

ifndef CROSS_COMPILE
would work in a makefile

Unfortunately I can't test any patches, since my mac is a mactel and works on both intel and ppc binaries ;-)
Ah, quite right.  Not sure how the merging works if a file is there for one arch but not for the other.  I'll test it right now.
Chances are good that merging doesn't work at all right now... we've never done UB XR builds before, see bug 345047
Posted patch patchSplinter Review
This patch gets the build past the JavaXPCOM errors I was seeing.  It now fails in xulrunner/installer/mac, but that's probably bug 345047.
Attachment #234076 - Flags: review?(benjamin)
Attachment #234076 - Flags: review?(benjamin) → review+
Checked in to trunk. ->FIXED
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment on attachment 234076 [details] [diff] [review]
patch

Seeking 1.8.1 approval.  While this patch touches the top level Makefile.in, it is XULRunner only (MOZ_JAVAXPCOM is only defined for XULRunner).
Attachment #234076 - Flags: approval1.8.1?
Comment on attachment 234076 [details] [diff] [review]
patch

a=beltzner on behalf of drivers, please land on MOZILLA_1_8_BRANCH and mark fixed1.8.1
Attachment #234076 - Flags: approval1.8.1? → approval1.8.1+
Comment on attachment 234076 [details] [diff] [review]
patch

Seeking 1.8.0.7 approval.  This patch is needed (along with the one from bug 345047) for creating Mac Universal builds of XULRunner.
Attachment #234076 - Flags: approval1.8.0.7?
Checked in to MOZILLA_1_8_BRANCH.
Keywords: fixed1.8.1
Comment on attachment 234076 [details] [diff] [review]
patch

approved for 1.8.0 branch, a=dveditz for drivers
Attachment #234076 - Flags: approval1.8.0.7? → approval1.8.0.7+
Checked in to MOZILLA_1_8_0_BRANCH.
Keywords: fixed1.8.0.7
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.