348911 - Spacing between toolbar icons regression

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Steve England [:stevee]]

See attached file. The spacing between the forward/back/reload/stop icons used to be equal and looked good on windows. Now they are not equal, look a bit strange, and take up unnecesasry space.

Comment 1

[Steve England [:stevee]]

Attachment: shows difference in toolbar icon spacing

Comment 2

[Ria Klaassen (not reading all bugmail)]

It is a regression between 1.8.1b1_2006081514 and 1.8.1b1_2006081606.

Comment 3

[Steve England [:stevee]]

Regression range from comment 2
http://tinderbox.mozilla.org/bonsai/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=MOZILLA_1_8_BRANCH&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-08-15+14%3A00%3A00&maxdate=2006-08-16+07%3A00%3A00&cvsroot=%2Fcvsroot

Bug 347470 or bug 348607 perhaps?

Comment 4

[Michael Wu [:mwu]]

Opps. I screwed up unbitrotting my patch before getting it checked in. Gavin's patch should fix this RSN. (bug 347416)

Comment 5

[Peter Kasting]

(In reply to comment #4)
> Gavin's patch should fix this RSN. (bug 347416)

I think this bug should be fixed for B2, and I'm not sure Gavin's bug will make that (the milestone is just Fx2).  Nominating for B2.  Michael, if you know how to fix this bitrot-bustage in an isolated way, consider posting a patch here so we can take it regardless of bug 347416...

Comment 6

[Michael Wu [:mwu]]

Attachment: Fix bitrot fix from bug 347470

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 234182 [details] [diff] [review]
Fix bitrot fix from bug 347470

a=beltzner on behalf of drivers, please land on MOZILLA_1_8_BRANCH and mark fixed1.8.1