When customizing toolbars, white box next to urlbar

RESOLVED FIXED in Firefox 2 beta2

Status

()

Firefox
Toolbars and Customization
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Peter Kasting, Assigned: mossop)

Tracking

({fixed1.8.1})

2.0 Branch
Firefox 2 beta2
x86
Linux
fixed1.8.1
Points:
---
Dependency tree / graph
Bug Flags:
blocking-firefox2 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

12 years ago
After the landing of bug 348431, there is now a large white box next to your location bar when customizing toolbars.  This looks broken.  Screenshot coming soon.
(Reporter)

Comment 1

12 years ago
Created attachment 234134 [details]
Strange-looking white box is circled
(Reporter)

Updated

12 years ago
Flags: blocking-firefox2?
Target Milestone: --- → Firefox 2
(Assignee)

Comment 2

12 years ago
At a guess this is the hidden drop down marker showing up differently in linux. I'll try to take a look at it this evening.

This isn't really related to the new theme.
No longer blocks: 347454

Updated

12 years ago
Flags: blocking-firefox2? → blocking-firefox2+
(Assignee)

Comment 3

12 years ago
Created attachment 234251 [details] [diff] [review]
patch rev 1

This patch changes to using display:none to hide the drop down. I have tested this under Linux and Windows and in both cases it gets rid of the remaining gap where the drop down was.
Assignee: nobody → mossop.bugzilla
Status: NEW → ASSIGNED
Attachment #234251 - Flags: review?(mconnor)
(Reporter)

Comment 4

12 years ago
Please note that bug 347616 and this bug affect may each other.  Especially if we draw a non-native dropdown, we may want to just make it inactive rather than hiding it.

Can the dropdown just be disabled during customize mode instead of hidden?
Comment on attachment 234251 [details] [diff] [review]
patch rev 1

r+a=me

this is at least a stopgap for b2
Attachment #234251 - Flags: review?(mconnor)
Attachment #234251 - Flags: review+
Attachment #234251 - Flags: approval1.8.1+
(Assignee)

Updated

12 years ago
Whiteboard: [checkin needed (1.8 branch)]
--> Firefox beta2 for stopgap

Please check in to branch, mark fixed1.8.1 and file a follow up for the proper fix.
Target Milestone: Firefox 2 → Firefox 2 beta2
(Reporter)

Comment 7

12 years ago
Checked in on branch.

/mozilla/browser/themes/winstripe/browser/browser.css 1.17.2.40
/mozilla/browser/themes/pinstripe/browser/browser.css 1.11.4.29
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [checkin needed (1.8 branch)]
Target Milestone: Firefox 2 beta2 → Firefox 2
(Reporter)

Updated

12 years ago
Blocks: 349184
(Reporter)

Updated

12 years ago
Target Milestone: Firefox 2 → Firefox 2 beta2
You need to log in before you can comment on or make changes to this bug.