Closed Bug 348946 Opened 18 years ago Closed 18 years ago

When customizing toolbars, white box next to urlbar

Categories

(Firefox :: Toolbars and Customization, defect)

Product:
Firefox
Component:
Toolbars and Customization
Version:
2.0 Branch
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 2 beta2

People

(Reporter: pkasting, Assigned: mossop)

References

Details

(Keywords: fixed1.8.1)

Attachments

(2 files)

Strange-looking white box is circled
4.58 KB, image/png
Details
patch rev 1
1.60 KB, patch
mconnor
: review+
mconnor
: approval1.8.1+
Details | Diff | Splinter Review 
After the landing of bug 348431, there is now a large white box next to your location bar when customizing toolbars.  This looks broken.  Screenshot coming soon.

    
  
Flags: blocking-firefox2?
Target Milestone: --- → Firefox 2

    
    

    
  
At a guess this is the hidden drop down marker showing up differently in linux. I'll try to take a look at it this evening.

This isn't really related to the new theme.

No longer blocks: NewTheme

    
  
Flags: blocking-firefox2? → blocking-firefox2+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch rev 1
        — 
          — Splinter Review
      

    


  
This patch changes to using display:none to hide the drop down. I have tested this under Linux and Windows and in both cases it gets rid of the remaining gap where the drop down was.
Assignee: nobody → mossop.bugzilla
Status: NEW → ASSIGNED

        Attachment #234251 -
        Flags: review?(mconnor)

    
    

    
  
Please note that bug 347616 and this bug affect may each other.  Especially if we draw a non-native dropdown, we may want to just make it inactive rather than hiding it.

Can the dropdown just be disabled during customize mode instead of hidden?

    
    

    
  
Comment on attachment 234251 [details] [diff] [review]
patch rev 1

r+a=me

this is at least a stopgap for b2

        Attachment #234251 -
        Flags: review?(mconnor)

        Attachment #234251 -
        Flags: review+

        Attachment #234251 -
        Flags: approval1.8.1+

    
  
Whiteboard: [checkin needed (1.8 branch)]

    
    

    
  
--> Firefox beta2 for stopgap

Please check in to branch, mark fixed1.8.1 and file a follow up for the proper fix.
Target Milestone: Firefox 2 → Firefox 2 beta2

    
    

    
  
Checked in on branch.

/mozilla/browser/themes/winstripe/browser/browser.css 1.17.2.40
/mozilla/browser/themes/pinstripe/browser/browser.css 1.11.4.29
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [checkin needed (1.8 branch)]
Target Milestone: Firefox 2 beta2 → Firefox 2

    
  
Blocks: 349184

    
  
Target Milestone: Firefox 2 → Firefox 2 beta2

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: