Closed Bug 349032 Opened 18 years ago Closed 18 years ago

Mac dmg built with official branding doesn't include background

Categories

(Calendar :: Sunbird Only, defect)

Product:
Calendar
Component:
Sunbird Only
Platform:
PowerPC
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Sunbird 0.3

People

(Reporter: mattwillis, Assigned: mattwillis)

Details

(Keywords: polish, Whiteboard: [patch in hand])

Attachments

(6 files)

rev0 - fixes stuff
3.52 KB, patch
cmtalbert
: first-review+
jminta
: second-review+
Details | Diff | Splinter Review
Generic calendar disk image icon
47.89 KB, image/png
Details
/mozilla/calendar/sunbird/app/macbuild/background.png
1.12 KB, image/png
Details
/mozilla/calendar/sunbird/app/macbuild/disk.icns
55.27 KB, application/octet-stream
Details
/mozilla/calendar/sunbird/app/macbuild/license.r
9.17 KB, application/octet-stream
Details
/mozilla/calendar/sunbird/app/macbuild/dsstore
6.00 KB, application/octet-stream
Details 
Due to an oversight in a makefile, building with official branding doesn't give you the pretty background image.
Nominating for blocking since it's easy and polish
Status: NEW → ASSIGNED
Flags: blocking0.3?
Attached patch rev0 - fixes stuff — — Splinter Review 
This patch switches on the use of background images, disk icons and the EULA in the Mac .dmg

/m/cal/sunbird/app/background.png is an all white .png, the same as Firefox.
I'll attach a screenshot of the icns icon.
dsstore you'll just have to trust me on. That file locates the icon and tells the Finder to use the background image.
Attachment #234320 - Flags: second-review?(jminta)
Attachment #234320 - Flags: first-review?(cmtalbert)
This icon is what disk.icns contains
Whiteboard: [patch in hand]
Not blocking.  The app is perfectly usable without this.  Would obviously accept patch.
Flags: blocking0.3? → blocking0.3-
Comment on attachment 234320 [details] [diff] [review]
rev0 - fixes stuff

Built fine. My build had some issues with the license.r file, but I believe that it is a local problem. I think the patch is fine.
Attachment #234320 - Flags: first-review?(cmtalbert) → first-review+
Comment on attachment 234320 [details] [diff] [review]
rev0 - fixes stuff

+MOZ_PKG_MAC_DSSTORE=branding/dsstore
I don't see where this file is in our tree and I don't see it attached to this  bug.  http://lxr.mozilla.org/seamonkey/find?string=dsstore
(In reply to comment #9)
> (From update of attachment 234320 [details] [diff] [review] [edit])
> +MOZ_PKG_MAC_DSSTORE=branding/dsstore
> I don't see where this file is in our tree and I don't see it attached to this 
> bug.  http://lxr.mozilla.org/seamonkey/find?string=dsstore

there's one currently in other-licenses. I've attached this one


Comment on attachment 234320 [details] [diff] [review]
rev0 - fixes stuff

ok, r2=jminta
Attachment #234320 - Flags: second-review?(jminta) → second-review+
Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: