349181 - [reflow branch] dropdown menus for autocomplete widgets don't resize properly

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Daniel Brooks [:db48x]]

The easiest way to reproduce is to type into the urlbar. The longer you type, the fewer urls will match, and eventually you'll narrow it down enough that the list will be shorter than the size of the dropdown menu. In a normal trunk build this causes the menu to get shorter while on the branch it stays the same size and just doesn't show anything in the remaining area.+

Comment 1

[Boris Zbarsky [:bzbarsky]]

Would it be possible to create a smaller XUL file showing this than the entire browser UI?  Needing to load it with -chrome is fine.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Minimal-ish testcase

This needs to be loaded as chrome to work.

Comment 3

[Boris Zbarsky [:bzbarsky]]

I should note that if I make menupopups not be reflow roots this bug persists, so this is not quite the same as bug 349585.

Comment 4

[Boris Zbarsky [:bzbarsky]]

So if I keep the popup as a reflow root and reset enough stuff in nsHTMLReflowState::InitConstraints I get the right behavior... So depending on what happens in bug 349585 this might start working.

And it needs to be a reflow root for the same reason as other popups -- the popupset (which is what reflows the popup) is not on the popup's parent chain, so the popup simply never gets reflown.  The only reason the display changes is that it's a tree, and trees don't need reflow to change what they look like.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Fixed by checking in that patch.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Er, I mean the patch in bug 349585.