349192 - Ship Thunderbird 1.5.0.x lt (Lithuanian)

Status: VERIFIED FIXED

(Thunderbird :: General, defect)

Description

[Rimas Kudelis [use needinfo to ping]]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; lt-LT; rv:1.8.0.5) Gecko/20060731 Ubuntu/dapper-security Firefox/1.5.0.5
Build Identifier: Thunderbird 1.5.0.x

While the Lithuanian translation of Thundebrird 2.0 is already in the CVS, it's not there in case of 1.5.0.x. However, it already exists, passes compare-locales.pl (at least seems to), and is quite well tested out, and available for download as a CE build for windows (http://ims.mii.lt/thunderbird/) and also as a cross-platform xpi file (http://files.akl.lt/Internetas/Mozilla-Thunderbird-LT/1.5/).

This is a request to accept it upstream. I heard from Axel, that Tb 2.0 is only planned to be released in 2007, so there's still a lot of time left, and I believe that it's not yet that useless to mess around with a (not that) new locale in 1.5 a little.

Reproducible: Always

Comment 1

[Rimas Kudelis [use needinfo to ping]]

Attachment: The proposed translation

Comment 2

[Rimas Kudelis [use needinfo to ping]]

Attachment: The proposed translation

The previously submitted patch had this already #expand'ed:
#expand <!ENTITY  lang.version          "__MOZILLA_LOCALE_VERSION__">

This one corrects the problem.

Comment 3

[Daniel Veditz [:dveditz]]

Axel: I think this is your call about whether this can make 1.5.0.7 -- I imagine there's not much trademark review in Thunderbird compared to Firefox.

Comment 4

[Axel Hecht [:Pike]]

Do we even have a tb 1.5.0.7?

Comment 5

[Daniel Veditz [:dveditz]]

Good point, it's not clear when. There *will* be a "next release" though and this language will have to be added to the appropriate tb lists.

Comment 6

[Daniel Veditz [:dveditz]]

Who will check this in to the 1.8.0 branch?

rhelmer: we'll need a patch for the ship-locales file as well.

Comment 7

[Rimas Kudelis [use needinfo to ping]]

I could check this in if somebody opens up the tree.

btw: is there an easy way to cvs-add such amount of files quickly?

Comment 8

[Daniel Veditz [:dveditz]]

The tree is open. It's "locked down" meaning only approved patches, but this one is approved.

Comment 9

[Daniel Veditz [:dveditz]]

Comment on attachment 234442 [details] [diff] [review]
The proposed translation

Approved to land on the 1.8.0 branch, a=dveditz for drivers

Comment 10

[Rimas Kudelis [use needinfo to ping]]

may I just commit the files now?

Comment 11

[David :Bienvenu]

yes, please commit the files. Thx.

Comment 12

[Rimas Kudelis [use needinfo to ping]]

Checked in.

Would you please add Tb in 1.8.0 to the list of what Tinderboxes build? (Axel?)

Comment 13

[Robert Helmer [:rhelmer]]

Attachment: add lt to shipped_locales

Comment 14

[Daniel Veditz [:dveditz]]

There was a surprise checkin this morning by [e-mail] to checkin forgotten files. Luckily for the LT team we slipped and the official builds hadn't started by then.

Rimas: make sure your team knows we're in the end-game here, and *everything* happens by exception. If you mess up a checkin, we need a new bug and approval request to cover fixing it. Yes, it slows things down, but it's critical that everyone know when we think things are done, when we're waiting on things, and when problems come up.

What are we waiting for to mark this bug "fixed1.8.0.7"? Trademark review? maybe we can split that off into its own bug to make things clearer.

Comment 15

[Axel Hecht [:Pike]]

I'm waiting for builds for the localization team to QA.
rhelmer, could you post a URL to good builds once they're done?
Tatjana, Rimas, once we have builds, please do some extensive testing via litmus and report the corresponding query URLs here?

Comment 16

[Rimas Kudelis [use needinfo to ping]]

(In reply to comment #14)
> There was a surprise checkin this morning by [e-mail] to
> checkin forgotten files. Luckily for the LT team we slipped and the official
> builds hadn't started by then.
> 
> Rimas: make sure your team knows we're in the end-game here, and *everything*
> happens by exception. If you mess up a checkin, we need a new bug and approval
> request to cover fixing it. Yes, it slows things down, but it's critical that
> everyone know when we think things are done, when we're waiting on things, and
> when problems come up.

Sorry for that. Those files don't seem to actually be used anywhere, so I thought we wouldn't need them for the build, so I didn't include them in the patch. Apparently, that was a bad assumption... I'll keep that in mind next time.

(In reply to comment #15)
> I'm waiting for builds for the localization team to QA.
> rhelmer, could you post a URL to good builds once they're done?
> Tatjana, Rimas, once we have builds, please do some extensive testing via
> litmus and report the corresponding query URLs here?

Sure. Whenever I get a link to a binary, I'll test it out. So far I can only see  thunderbird-1.5.0.5.lt.* files in ftp://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/latest-mozilla1.8.0-l10n/. Is that the right place to check?

Comment 17

[Axel Hecht [:Pike]]

The builds are on, and we're seeing the following problems still, as of
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla1.8.0-l10n-lt/1157738220.20087.gz&fulltext=1:

iconv -f UTF-8 -t CP1257 /cygdrive/c/builds/tinderbox/Tb-Mozilla1.8.0-l10n-Release/WINNT_5.2_Clobber/mozilla/../l10n/lt/mail/installer/installer.inc > \
  installer.inc
iconv: /cygdrive/c/builds/tinderbox/Tb-Mozilla1.8.0-l10n-Release/WINNT_5.2_Clobber/mozilla/../l10n/lt/mail/installer/installer.inc: cannot convert
make[2]: *** [repackage-win32-installer] Error 1

... plus ...

Properties in ./chrome/messenger/messengercompose/composeMsgs.properties don't match:
  In c:/builds/tinderbox/Tb-Mozilla1.8.0-l10n-Release/WINNT_5.2_Clobber/mozilla/mail/locales/en-US: (add these to your localization)
    sendMsgTitle
  In c:/builds/tinderbox/Tb-Mozilla1.8.0-l10n-Release/WINNT_5.2_Clobber/mozilla/../l10n/lt/mail: (remove these from your localization)
    subjectDlogTitle

Dan, this missed the train, could you '-' the blocking1.8.0.7 flag and request the blocking1.8.0.8 flag, then we can reevaluate this for the next round.

Tatjana, Rimas, please file bugs on these issues, or one, and make them block this bug. Request blocking flags on the bugs and approval on the patches for 1.8.0.8, so that we can land those fixes in the next engineering period. Once they get approved, of course.

Comment 18

[Axel Hecht [:Pike]]

Comment on attachment 235817 [details] [diff] [review]
add lt to shipped_locales

Unsetting the review flag, the patch is good, the time sadly is not.

Comment 19

[Rimas Kudelis [use needinfo to ping]]

(In reply to comment #17)

Axel, I don't see the errors you mentioned in the latest build. I think you're mistaken. These errors have been fixed days ago, and it's weird they show up now. Could it be something wrong with the tinderboxes maybe?

http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla1.8.0-l10n-lt/1157778240.10770.gz&fulltext=1

Comment 20

[Axel Hecht [:Pike]]

Rob, on 
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla1.8.0-l10n/1157737039.1264.gz&fulltext=1
which is the windows build log you mailed to me, the pull date for l10n is

mk_add_options MOZ_CO_LOCALES_DATE="19 Jul 2006 00:00:00 +0000"

and not "2006-08-31 00:00:00 PDT" as your mail said.

I didn't check the other builds, but please reconfirm all l10n builds, including the tagged firefox tree. That pulls l10n from the release tag, but we should verify that that's the right status of the tree.

Comment 21

[Robert Helmer [:rhelmer]]

(In reply to comment #20)
> Rob, on 
> http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla1.8.0-l10n/1157737039.1264.gz&fulltext=1
> which is the windows build log you mailed to me, the pull date for l10n is
> 
> mk_add_options MOZ_CO_LOCALES_DATE="19 Jul 2006 00:00:00 +0000"
> 
> and not "2006-08-31 00:00:00 PDT" as your mail said.
> 
> I didn't check the other builds, but please reconfirm all l10n builds,
> including the tagged firefox tree. That pulls l10n from the release tag, but we
> should verify that that's the right status of the tree.
> 


Axel, looks like you are right and these are not configured correctly. It looks like we are going to respin en-US again anyway, so I am going to wait until then to respin the l10n builds. 

Comment 22

[Axel Hecht [:Pike]]

Mind re-requesting review on the shipped-locales patch when the builds are done and green? They really should be, as the nightlies were.
Sorry for not catching that the first round.

Comment 23

[Rimas Kudelis [use needinfo to ping]]

Comment on attachment 235817 [details] [diff] [review]
add lt to shipped_locales

We finally have green Clobber builds here:
http://tinderbox.mozilla.org/showbuilds.cgi?tree=Mozilla1.8.0-l10n-lt&maxdate=1157947981&legend=0

Comment 24

[Axel Hecht [:Pike]]

Comment on attachment 235817 [details] [diff] [review]
add lt to shipped_locales

We have a sign-off and should be good to go.

Comment 25

[Axel Hecht [:Pike]]

Comment on attachment 235817 [details] [diff] [review]
add lt to shipped_locales

We have a sign-off and should be good to go.

Comment 26

[Robert Helmer [:rhelmer]]

checked into MOZILLA_1_8_0_BRANCH:

Checking in shipped-locales;
/cvsroot/mozilla/mail/locales/Attic/shipped-locales,v  <--  shipped-locales
new revision: 1.1.2.1.2.2; previous revision: 1.1.2.1.2.1
done

Comment 27

[Reed Loden [:reed]]

Not really sure why attachment 234442 [details] [diff] [review] says "approval1.8.0.9+", as that patch was committed a long time ago. However, setting fixed1.8.0.9 keyword to get it off the not-committed list.