349255 - [reflow branch] Horizontal scrollbar on annevankesteren blog

Status: RESOLVED DUPLICATE of bug 478834

(Core :: Layout, defect, P2)

Description

[Martijn Wargers (dead)]

I get a horizontal scrollbar on the annevankesteren blog with the reflow branch, which should not happen.

Comment 1

[Martijn Wargers (dead)]

Attachment: testcase

Comment 2

[Boris Zbarsky [:bzbarsky]]

So the problem is that block-level replaced elements can end up next to floats, but nsBlockFrame::GetPrefWidth does a Break() on any block line without considering floats.  We probably need to modify one or the other...

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

For what it's worth -- what the intrinsic width here should be is questionable.  But there's definitely a bug here in the reflow code for replaced blocks (in general) -- we should clear them past floats when they don't fit next to the floats.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The clearing past floats in comment 3 would also fix the image at the top right of http://www.nytimes.com/2007/11/26/opinion/26krugman.html?pagewanted=print from overflowing at narrow window widths.

Comment 5

[Gábor Stefanik]

Repro'd on Mac.
->All/All

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fixed by checkin of bug 134706.

Comment 7

[Ria Klaassen (not reading all bugmail)]

Bug 437766 seems to be a duplicate. For some reason the scrollbar is still visible here; I tried builds before and after the fix.

Comment 8

[Gábor Stefanik]

The testcase no longer reproduces the bug, but it's still visible on Anne's site. (I'm on Linux with RC2.)

Comment 9

[Gábor Stefanik]

Attachment: New testcase

This testcase still reproduces the bug for me. However, I am not sure if it's really a bug, as Konqueror also displays a horizontal scrollbar.

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I'd guess that the problem there would be that nsBlockFrame::BlockCanIntersectFloats is somehow returning true for the submit input when it should really be returning false.

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Actually, it seems like the problem is that ApplyTopMargin is false in nsBlockFrame::ReflowBlockFrame, so we don't do the clearing.

Comment 13

[j.j.]

Attachment: New testcase 2

a bit reduced and generalized

Comment 14

[Damon Sicore (:damons)]

Not going to block 1.9.1, but a P2 wanted.   

Comment 15

[Gábor Stefanik]

Another example in the wild is http://www.allpcdrivers.com/

Comment 16

[Guilherme Lima]

Still a problem on Nightly 27. Works correctly on Chrome 29 and IE10.

Comment 17

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Both attachment 324199 [details] and attachment 324312 [details] were fixed by bug 478834.