349265 - When using Modify Query, dates entered are clobbered (set to UNIX time)

Status: RESOLVED FIXED

(Webtools Graveyard :: Bonsai, defect)

Description

[Adam Guthrie]

Steps to reproduce:
1. Go to http://bonsai.mozilla.org/cvsqueryform.cgi.
2. Enter in a date range to search in and submit the query; e.g. 2006-01-01 and 2006-01-02.
3. Click the Modify Query link to modify the query.

Results:
Dates in the forms are now in UNIX time.

Expected Results:
Dates are shown in ISO format, as I entered them.

Comment 1

[Jeremy Baron]

Attachment: v1

Comment 2

[Jeremy Baron]

Comment on attachment 244235 [details] [diff] [review]
v1

I'm not sure how this will work with time zones, so please double check that that is working properly.

Comment 3

[Mike Taylor [:bear]]

*** Bug 323410 has been marked as a duplicate of this bug. ***

Comment 4

[Jeremy Baron]

The other bug mentioned in justdave's dupe of this (Bug 323410) is Bug 358955.

Comment 5

[Dave Miller [:justdave]]

Comment on attachment 244235 [details] [diff] [review]
v1

looks good

Comment 6

[Dave Miller [:justdave]]

do you have checkin privs or do you need someone to check this in for you?

Comment 7

[Reed Loden [:reed]]

(In reply to comment #6)
> do you have checkin privs or do you need someone to check this in for you?

He needs somebody to check it in for him. I can do it if you don't have a working tree.

Comment 8

[Mike Taylor [:bear]]

I'll do it now

Comment 9

[Mike Taylor [:bear]]

Checking in cvsqueryform.cgi;
/cvsroot/mozilla/webtools/bonsai/cvsqueryform.cgi,v  <--  cvsqueryform.cgi
new revision: 1.27; previous revision: 1.26
done

Comment 10

[Adam Guthrie]

Reopening. There's a problem with this patch: if no date is in the field to begin with, it gets filled in with the default UNIX time.

Comment 11

[Jeremy Baron]

Attachment: secondpatch - v1

This fixes a regression introduced with the first patch on this bug.  This patch is untested.

Comment 12

[Reed Loden [:reed]]

Checking in cvsqueryform.cgi;
/cvsroot/mozilla/webtools/bonsai/cvsqueryform.cgi,v  <--  cvsqueryform.cgi
new revision: 1.28; previous revision: 1.27
done