349298 - "let" statement in "for" causes "Assertion failure: !let || tc->topStmt == tc->topScopeStmt"

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect, P2)

Description

[Jesse Ruderman]

javascript:function() { for(i=0;i<4;++i) let x = 4; }

causes

Assertion failure: !let || tc->topStmt == tc->topScopeStmt, 
at mozilla/js/src/jsparse.c:3458

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Fix bogo-assertion

We don't really care what tc->topScopeStmt is...

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

I meant tc->topStmt.

Comment 3

[Brendan Eich [:brendan]]

Comment on attachment 234598 [details] [diff] [review]
Fix bogo-assertion

This is debug only and can go into the 1.8 branch any time drivers want.  It's needed for 1.8.1/fx2.

/be

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Fixed on trunk.

Comment 5

[Bob Clary [:bc] (inactive)]

Checking in regress-349298.js;
/cvsroot/mozilla/js/tests/js1_7/block/regress-349298.js,v  <--  regress-349298.js
initial revision: 1.1

Comment 6

[Bob Clary [:bc] (inactive)]

verified fixed 1.9 20060821 windows/mac*/linux

Comment 7

[Mike Schroepfer]

Comment on attachment 234598 [details] [diff] [review]
Fix bogo-assertion

a=schrep for drivers - approving all [181approval pending] bugs now that the tree is open.

Comment 8

[Brendan Eich [:brendan]]

Fixed on the 1.8 branch.

/be

Comment 9

[Bob Clary [:bc] (inactive)]

verified fixed 1.8 20060824 windows/mac*/linux