warn about leading and trailing spaces in filename search

RESOLVED FIXED

Status

Webtools
MXR
RESOLVED FIXED
11 years ago
9 years ago

People

(Reporter: Eyal Rozenberg, Assigned: timeless)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

(Reporter)

Description

11 years ago
I just searched for "tabbrowser.xml " since I pasted an extra space by mistake, and got no results. Without the space I of course got the two files. Why doesn't the default search by filenames (not regexp search, that's a different story) strip excess spaces from the end of the search term?
filename search _is_ a regex search fwiw
(Reporter)

Comment 2

11 years ago
> filename search _is_ a regex search fwiw

Hmm, didn't notice that. In that case, let's open another bug: Bug 349315.
(Assignee)

Comment 3

11 years ago
reporter: in the future, please properly use the bugzilla bug tracking system when filing bugs.

at the very least, that includes:
A. filling the url field. this isn't hard as most web browsers have a copy feature and oddly enough, the have paste too.
B. include steps to reproduce, that means things like

1. load lxr.mozilla.org/seamonkey
2. click search
3. read and the inconspicuous text that reads:
Search for files (by name) using regular expressions.
(Need some Hints on performing searches?) - or go home
4. paste "tabbrowser.xml " into the field
5. click search

C. include expected results
"I expect this feature to do something entirely unrelated to what it clearly says it will do:
namely search for the file name as a trimmed substring search"

D. include actual results:
Taken to a page whose URL is:
http://lxr.mozilla.org/seamonkey/find?string=tabbrowser.xml+

E. Be reasonable.

I'm willing to consider fixing the bug that you should have filed, but this bug as it was filed is awful. Note that there are multiple entry points to find and I'm willing to bet that you *didn't* choose the one I did, which is *precisely* why steps to reproduce are important.

Note that there are various flavors of expected results.
Summary: filename search fails with extra space present → filename search for file with trailing space results in no matches for files that don't have trailing spaces in their name
QA Contact: timeless → lxr
(Assignee)

Comment 4

9 years ago
here are some examples of why being able to search for spaces is important:
http://mxr-test.landfill.bugzilla.org/mozilla/find?string=Release+
/camino/docs/Release Notes 0-5.rtf
http://mxr-test.landfill.bugzilla.org/mozilla/find?string=%20Plugin
/modules/plugin/tools/sdk/samples/basic/mac/Basic Plugin.mcp
Assignee: bear → timeless
(Assignee)

Comment 5

9 years ago
changeset 97  	5cb52beae193
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Summary: filename search for file with trailing space results in no matches for files that don't have trailing spaces in their name → warn about leading and trailing spaces in filename search
You need to log in before you can comment on or make changes to this bug.