349314 - onpopuphiding now fires before oncommand -> crash [PresShell::HandleDOMEventWithTarget]

Status: RESOLVED DUPLICATE of bug 323628

(Firefox :: General, defect)

Description

[Mikel Ward]

I have written a small Firefox extension that uses the following XUL snippet to add a menu called "Tabs" to the main menu bar.

      <menupopup id="menu_TabsPopup"
                 onpopupshowing="createTabsMenu(this)"
                 onpopuphiding="destroyTabsMenu(this)"
                 oncommand="selectTab(event)">


This worked in Firefox 1.0 thru 1.5, but in 2.0b1, clicking on the menu then on an item causes a crash.

By inserting some debug messages, I can see the event handling has changed.

1) install the Tabs Menu extension
2) restart
3) create two tabs
4) click on the Tabs menu
5) click on 1 - <page title>

In Firefox 1.5, you should see the following alert messages:
* Creating menu
* Selecting item
* Destroying menu

In Firefox 2.0b1, all you see is
* Creating menu
* Destroying menu

then the browser crashes.

Not sure if this is a Firefox bug or a Mozilla Toolkit bug.

Comment 1

[Mikel Ward]

Attachment: Firefox extension with debug messages on entering each function

Install this version of Tabs Menu to see the described debug messages.

Comment 2

[Ria Klaassen (not reading all bugmail)]

TB22263720Z  TB22262829Z 
This is repaired on trunk between 1.9a1_2006030704 and 1.9a1_2006030713:
http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=2006-03-07+03%3A00&maxdate=2006-03-07+14%3A00
See also Bug 323628 comment 4.

Comment 3

[Ria Klaassen (not reading all bugmail)]

Incident ID: 22263720
Stack Signature	PresShell::HandleDOMEventWithTarget be6b8a60
Product ID	Firefox2
Build ID	2006081803
Trigger Time	2006-08-19 07:50:38.0
Platform	Win32
Operating System	Windows NT 5.1 build 2600
Module	firefox.exe + (0017b902)
URL visited	
User Comments	
Since Last Crash	12 sec
Total Uptime	30127 sec
Trigger Reason	Access violation
Source File, Line No.	c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/layout/base/nsPresShell.cpp, line 6519
Stack Trace 	
PresShell::HandleDOMEventWithTarget  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/layout/base/nsPresShell.cpp, line 6519]
nsMenuFrame::Execute  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/layout/xul/base/src/nsMenuFrame.cpp, line 1682]
nsMenuFrame::HandleEvent  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/layout/xul/base/src/nsMenuFrame.cpp, line 481]
PresShell::HandleEventInternal  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/layout/base/nsPresShell.cpp, line 6464]
PresShell::HandleEvent  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/layout/base/nsPresShell.cpp, line 6259]
nsViewManager::HandleEvent  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/view/src/nsViewManager.cpp, line 2543]
nsViewManager::DispatchEvent  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/view/src/nsViewManager.cpp, line 2256]
FindNonAutoZIndex  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/view/src/nsView.cpp, line 636]
nsWindow::DispatchEvent  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/widget/src/windows/nsWindow.cpp, line 1343]
nsWindow::DispatchMouseEvent  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/widget/src/windows/nsWindow.cpp, line 6257]
ChildWindow::DispatchMouseEvent  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/widget/src/windows/nsWindow.cpp, line 6504]
nsWindow::WindowProc  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/widget/src/windows/nsWindow.cpp, line 1531]
USER32.dll + 0x8734 (0x77d18734)
USER32.dll + 0x8816 (0x77d18816)
USER32.dll + 0x89cd (0x77d189cd)
USER32.dll + 0x8a10 (0x77d18a10)
nsAppShell::Run  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/widget/src/windows/nsAppShell.cpp, line 159]
nsAppStartup::Quit  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/toolkit/components/startup/src/nsAppStartup.cpp, line 189]
main  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/browser/app/nsBrowserApp.cpp, line 61]
kernel32.dll + 0x16fd7 (0x7c816fd7)

Comment 4

[Adam Guthrie]

*** This bug has been marked as a duplicate of 323628 ***