Closed
Bug 349377
Opened 18 years ago
Closed 18 years ago
Many Lightning source files need license headers
Categories
(Calendar :: Lightning Only, defect)
Calendar
Lightning Only
Tracking
(Not tracked)
RESOLVED
FIXED
Lightning 0.3
People
(Reporter: mattwillis, Assigned: mattwillis)
Details
Attachments
(1 file, 1 obsolete file)
38.47 KB,
patch
|
jminta
:
first-review+
|
Details | Diff | Splinter Review |
A bunch of the Lightning source files never got license headers. We should fix that before 0.3 goes out.
Assignee | ||
Comment 1•18 years ago
|
||
Adds missing license headers to Lightning source files. The contributors list is set from the information in cvs log.
Assignee: nobody → mattwillis
Status: NEW → ASSIGNED
Attachment #234639 -
Flags: first-review?(jminta)
Comment 2•18 years ago
|
||
Comment on attachment 234639 [details] [diff] [review] Adds missing license headers. Contributors distilled from cvs log. > var cView = currentView(); > if (cView.displayCalendar) { > cView.goToDay(cView.selectedDay); >- } > >+ } >+ > Hmm, how about no? :-) Also, you need to look at the checkin comments more closely. I can see some 'patch by' checkins that aren't noted here.
Assignee | ||
Comment 3•18 years ago
|
||
(In reply to comment #2) > (From update of attachment 234639 [details] [diff] [review] [edit]) > > var cView = currentView(); > > if (cView.displayCalendar) { > > cView.goToDay(cView.selectedDay); > >- } > > > >+ } > >+ > > > Hmm, how about no? :-) That's due to an errant ^M in the file. I'll clean that up in a separate commit before I land this. > Also, you need to look at the checkin comments more closely. I can see some > 'patch by' checkins that aren't noted here. I thought I had done that. Clearly I missed a bunch. I just went back through and added/fixed the ones I missed.
Attachment #234639 -
Attachment is obsolete: true
Attachment #234797 -
Flags: first-review?(jminta)
Attachment #234639 -
Flags: first-review?(jminta)
Comment 4•18 years ago
|
||
Comment on attachment 234797 [details] [diff] [review] Fixed per jminta's comments -<?xml version="1.0"?> +<?xml version="1.0" encoding="UTF-8"?> Let's just do license stuff here. -</overlay> \ No newline at end of file +</overlay> But bonus points if you fix that. r=jminta
Attachment #234797 -
Flags: first-review?(jminta) → first-review+
Assignee | ||
Comment 5•18 years ago
|
||
Patch with nits checked in on MOZILLA_1_8_BRANCH and trunk. -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•