349408 - Reflow builds query the nightly update channel and get updated to non-reflow trunk

Status: RESOLVED FIXED

(Webtools Graveyard :: Tinderbox, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

This is a followup to bug 349183, based on a report from NeoThermic on IRC. 

If you install a Reflow branch build then it will check for updates on the nightly channel, and be updated to the latest Firefox trunk build. Disabling the --enable-update-channel line in the mozconfig will prevent the update check.

NeoThermic wondered if there could be proper updates for the reflow builds,, but lets fix the unintended updates first. :-)

Comment 1

[Robert Helmer [:rhelmer]]

(In reply to comment #0)
> This is a followup to bug 349183, based on a report from NeoThermic on IRC. 
> 
> If you install a Reflow branch build then it will check for updates on the
> nightly channel, and be updated to the latest Firefox trunk build. Disabling
> the --enable-update-channel line in the mozconfig will prevent the update
> check.
> 
> NeoThermic wondered if there could be proper updates for the reflow builds,,
> but lets fix the unintended updates first. :-)


This is a good point. The only things we can do right now seem to be:

* change the channel
* change the version number (e.g. "3.0a1reflow"

Any ideas? I think changing the version number will make it easier to identify the build, and also make it possible to get updates turned on for the reflow branch in the future.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

In reply to comment #1:

Either solution would be sufficient to disentangle the current situation I think.

If updates were wanted, it could possibly work like this:

tinder-config.pl (T'box)
  $update_version="reflow"       # to keep the data seperate in AUS

browser/config/version.txt (REFLOW branch source)
  3.0a1-reflow                   # to give us something to recognise the build

config-dist.php (AUS)
  '3.0a1-reflow' => 'reflow',    # map the app version to the update data

mozconfig (T'box)
  ac_add_options --enable-update-channel=nightly
                        # leave it on nightly for the sake of the logic in AUS

I haven't looked at the patcher code though. It would be good for morgamic to comment on AUS side, and dbaron on whether updates are desirable.

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Not having updates is fine, if that's easier.

Comment 4

[Robert Helmer [:rhelmer]]

updates are now disabled for the reflow branch win32 tinderbox.