Image blocking notification shows the wrong host name for third party images.

RESOLVED FIXED in Firefox 2

Status

()

Firefox
General
--
major
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Brian Polidoro, Assigned: Gavin)

Tracking

({fixed1.8.1, testcase})

2.0 Branch
Firefox 2
fixed1.8.1, testcase
Points:
---
Bug Flags:
blocking-firefox2 +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Fx2b2 rider], URL)

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

11 years ago
When blocking a third party image on a web site, the web site's host name is displayed instead of the third party host name.

One example I see is on news8.net.  Some of the images are from wjla.com.  And others are from an ip address.  Blocking either of these will give the notification that images are blocked from news8.net.  Which that is not the case. 

Actual:
When blocking a third party image the host name of the web site is shown.

Expected:
When blocking a third party image show the host name of the third party server.

The context menu correctly shows the third party host name.  e.g. Block Images from wjla.com.
(Reporter)

Comment 1

11 years ago
This is possibly worse than when the message was ambiguous (Bug 346728).  Then you could assume the site being blocked was the one you meant.  Now the notification could be explicitly wrong because it's blocking one site while saying it's blocking another.  
Flags: blocking-firefox2?
The patch for bug 346486 was wrong: not only does it redeclare "uri", it changes it to the host of the page when it's already the URI being blocked.
Blocks: 346486
Severity: normal → major
OS: Windows XP → All
Hardware: PC → All
Version: Trunk → 2.0 Branch

Comment 3

11 years ago
I can have this done tomorrow.  If someone wants to take it before then, feel free.
Created attachment 234716 [details]
testcase
Comment on attachment 234716 [details]
testcase

er, wrong attachment
Attachment #234716 - Attachment is obsolete: true
Created attachment 234718 [details]
testcase
Keywords: testcase
Created attachment 234719 [details] [diff] [review]
patch
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #234719 - Flags: review?(mconnor)
Target Milestone: --- → Firefox 2 beta2
Flags: blocking-firefox2? → blocking-firefox2+
Target Milestone: Firefox 2 beta2 → Firefox 2
Whiteboard: [Fx2b2 rider]

Updated

11 years ago
Attachment #234719 - Flags: review?(mconnor)
Attachment #234719 - Flags: review+
Attachment #234719 - Flags: approval1.8.1?
mozilla/browser/base/content/browser.js 	1.689
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Fx2b2 rider] → [Fx2b2 rider][181approval pending]
Whiteboard: [Fx2b2 rider][181approval pending] → [181approval pending][Fx2b2 rider]

Comment 9

11 years ago
Comment on attachment 234719 [details] [diff] [review]
patch

a=schrep for drivers - approving all [181approval pending] bugs now that tree is open.
Attachment #234719 - Flags: approval1.8.1? → approval1.8.1+
Whiteboard: [181approval pending][Fx2b2 rider] → [checkin needed (1.8 branch)][Fx2b2 rider]
mozilla/browser/base/content/browser.js 	1.479.2.191
Keywords: fixed1.8.1
Whiteboard: [checkin needed (1.8 branch)][Fx2b2 rider] → [Fx2b2 rider]
You need to log in before you can comment on or make changes to this bug.