349419 - "Unexpected load type value" assertion after entering a URL needing fixup

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P3)

Description

[Andrew Schultz]

With the patch from bug 332668, I'm hitting the assertion from bug 341112,
###!!! ASSERTION: Unexpected load type value: 'Not Reached', file /build/andrew/moz-debug/mozilla/docshell/base/nsDocShell.cpp, line 646

I seem to get it anytime I enter a URL that needs fixup.  "fooby" and "mozilla.org" trigger the assertion, but "http://www.mozilla.org/" does not.  I also hit the assertion with a trunk build of firefox.

Comment 1

[Andrew Schultz]

Attachment: stacktrace from assertion

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Attachment: fixes the assertion by introducing a new nsIDocShellLoadInfo type

I'm not entirely familiar with this load type code, but this fixes the assertion for me...

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 234708 [details] [diff] [review]
fixes the assertion by introducing a new nsIDocShellLoadInfo type

looks ok to me

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 234708 [details] [diff] [review]
fixes the assertion by introducing a new nsIDocShellLoadInfo type

Man.  We so need to fix this mess.  Can we find someone to do it for 1.9?

sr=bzbarsky

Comment 5

[:Gavin Sharp [email: [e-mail]]]

mozilla/docshell/base/nsDocShellLoadTypes.h 	1.3
mozilla/docshell/base/nsDocShell.cpp 	1.815
mozilla/docshell/base/nsIDocShellLoadInfo.idl 	1.22

Comment 6

[Boris Zbarsky [:bzbarsky]]

Case in point -- this patch is actually wrong.  See bug 351777.  :(