349420 - Live Bookmark Icon slightly off center in the bookmarks menu

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[(not reading, please use [e-mail] instead)]

Live Bookmark Icon slightly off center in the bookmarks menu

I'll attach a screen shot.

this is after the fixes for bug #347435 and #347719

I am using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060819 BonEcho/2.0b2

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: the red lines I've added to help see the problem

Comment 2

[(not reading, please use [e-mail] instead)]

probably not a blocker, but since it is a regression, it would be nice to fix this before we ship.

Comment 3

[(not reading, please use [e-mail] instead)]

in bug #347435, chris ilias <[e-mail]> writes:

> IMO, this bug is not fixed entirely. Firefox2 puts a border around the livemark
> icon, when it is selected; but when the icon is not selected, the space for the
> border, makes the icon appear misaligned.
> See <http://ilias.ca/Bug347435.html>.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: inappropriate hover state

The hover state shouldn't have a border around it, either; I think we're just using the wrong regions here.

Comment 5

[Phil Ringnalda (:philor)]

*** Bug 350144 has been marked as a duplicate of this bug. ***

Comment 6

[Jackie Liu]

Attachment: Hover highlight too large caused by inappropriate hover state

Since Bug 350144 has been duped to this bug, this attachment illustrates the problem of the hover highlight being too large compared to other hover highlights caused by the inappropriate hover state.

Comment 7

[Arpad Borsos [:Swatinem]]

The new Icon is 18x18 whereas the other ones (and the old feed icon) are 16x16 AFAIK. I vote for reverting to the old Feed Icon, the new glow doesn't look good anyway.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Attachment: use a seperate image for the menus/toolbar

I considered just tweaking the regions on the images to remove the unnecessary highlight effect, but that doesn't entirely fix the alignment in the menu, since other menuitem icons are 16x16 with some padding included in the image, and that's not possible with the current "hover" icon. Instead, I split the images out into livemark-folder. I'll attach the new images next.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Attachment: images (extract in mozilla/)

Comment 10

[Mike Connor [:mconnor]]

Comment on attachment 235401 [details] [diff] [review]
use a seperate image for the menus/toolbar

r+a=me for this theme change.  Thanks Gavin!

Comment 11

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/themes/winstripe/browser/livemark-folder.png 	1.1.2.1
mozilla/browser/themes/winstripe/browser/livemark-folder-rtl.png 	1.1.2.1
mozilla/browser/themes/winstripe/browser/jar.mn 	1.13.2.18
mozilla/browser/themes/winstripe/browser/browser.css 	1.17.2.44