349438 - bug 266945 enhanced / followup

Status: RESOLVED FIXED

(Toolkit :: Password Manager, enhancement)

Description

[Serge Gautherie (:sgautherie)]

See bug 266945 comment 32.

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) enhanced [Checkin: Comment 9]

See bug 266945 comment 31.

Comment 2

[Axel Hecht [:Pike]]

Not that this is easy to approve as it is, as it would involve reverse engineering bug 266945, this is late-l10n, too.

Comment 3

[aveclafaux]

I would sya - make the 'No' button by default only for the time beeing and save the string change for later.
The No-by-default is a nice and simple UI enhancement IMHO.

Comment 4

[Serge Gautherie (:sgautherie)]

Sure,
the whole patch can go into the Trunk,
and you may take whenever/whatever part you want for the 1.8.1 branch.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

If we respin, we'll take this late-l10n change on branch, if not, it waits for Firefox3. We'll take the change to the default button change (whip up a different patch for that?) even after beta2.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 234706 [details] [diff] [review]
(Av1) enhanced
[Checkin: Comment 9]

Need a new patch that doesn't change strings.

Comment 7

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1-181) enhanced [Checkin: Comment 10]

Code only patch, as requested for 1.8.1 branch.

Comment 8

[Mike Connor [:mconnor]]

Comment on attachment 234976 [details] [diff] [review]
(Bv1-181) enhanced
[Checkin: Comment 10]

carrying over r+

a=mconnor on behalf of drivers for checkin to 1.8 branch

Comment 9

[Serge Gautherie (:sgautherie)]

Comment on attachment 234706 [details] [diff] [review]
(Av1) enhanced
[Checkin: Comment 9]


Checkin: {
2006-08-24 10:34	bugzilla%standard8.demon.co.uk
}

Comment 10

[:Gavin Sharp [email: [e-mail]]]

mozilla/toolkit/components/passwordmgr/resources/content/passwordManager.js 	1.11.4.4