349481 - Clear private data dialog width is hardcoded

Status: RESOLVED FIXED

(Firefox :: General, defect, P2)

Description

[Michele Dal Corso]

The dialog "Clear Private Data" accessible from Firefox Preferences -> Privacy tab -> Settings button, should be made resizable via entities in the l10n file (/chrome/browser/preferences/sanitize.dtd )

Comment 1

[Michele Dal Corso]

Attachment: How the dialog (translated in Italian) appears in OSX

Comment 2

[Axel Hecht [:Pike]]

Is this a regression?

Comment 3

[Michele Dal Corso]

I made an error: the involved dialog is the Options -> Clear private data... and not the Preferences dialog (/chrome/browser/sanitize.dtd and NOT /chrome/browser/preferences/sanitize.dtd )

My apologies for this.

Comment 4

[Michele Dal Corso]

The url is still wrong. Sorry for the bugspam. Francesco will add ASAP details compared to 1.8.0 branch.

Comment 5

[Francesco Lodolo [:flod]]

Attachment: Dialog in Firefox 1.5.0.6 for Mac Os X

Comment 6

[Francesco Lodolo [:flod]]

(In reply to comment #2)
> Is this a regression?

Probably yes. 

The structure of that dialog window is slightly different in Firefox 1.5.x; even if it's not resizable using entities, this dialog is displayed correctly (although  I've just noticed a little cut in the decoration at the bottom).

Comment 7

[Axel Hecht [:Pike]]

I'm not sure if I'd call this a regression.

Anyway, this is a UI decision, localizations may loose the "Authenticated Sessions" entry in the dialog Tools -> Clear private data.

Requesting blocking for drivers to evaluate.

Comment 8

[Axel Hecht [:Pike]]

Can you hack around this via intl.css?

Comment 9

[Michele Dal Corso]

(In reply to comment #8)
> Can you hack around this via intl.css?

Maybe yes: the dialog has a SanitizeDialog id and style attribute set to "width: 30em ! important;".
An entry like this:

#SanitizeDialog {
  width: XXem;
}

will works?

However for now I shortened the translation of the line that wraps to fit the windows.
To mantain consistency with other dialogs size settings maybe this shold be changed.

Comment 10

[Axel Hecht [:Pike]]

You likely still need an !important, and you may want to make it more specific still by using @-moz-document, http://lists.w3.org/Archives/Public/www-style/2004Aug/0135.html.

Comment 11

[Michele Dal Corso]

Ok! This is right? Now I check if it works.

@-moz-document url(chrome://browser/content/sanitize.xul) {
   prefwindow#SanitizeDialog {
      width: XXem !important;
   }
}

Comment 12

[Michele Dal Corso]

I made some tests: changing width is not allowed, I think because the hard-coded style has priority over intl.css styles.

I can change only the height with this style code:

@-moz-document url(chrome://browser/content/sanitize.xul) {
   #SanitizeDialog {
      height: XXem !important;
   }
}

Francesco should determine the right height vaule.

Comment 13

[Axel Hecht [:Pike]]

Cancelling branch magic, that's good enough as a workaround.
This should be fixed on the trunk, of course, but I just deny that this is an issue for Firefox 2.
Once you have a working workaround, could you post to .l10n? Then every locale suffering from a line-wrap can reuse that.

Comment 14

[Axel Hecht [:Pike]]

*** Bug 352965 has been marked as a duplicate of this bug. ***

Comment 15

[Asaf Romano (gone)]

Attachment: patch

Comment 16

[:Gavin Sharp [email: [e-mail]]]

The patch for bug 345769 seems to have removed the l10n-specified width, and commented out its reference in the other sanitize.xul (http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/components/preferences/sanitize.xul&rev=1.14&mark=53,54#53).

Jeff, do you remember why? Can that be restored when this patch lands?

Comment 17

[Jeff Walden [:Waldo]]

(In reply to comment #16)
> Jeff, do you remember why? Can that be restored when this patch lands?

I don't remember.  The most reasonable guess is that I saw it, couldn't determine why it was useful, and thus commented it out in the interests of removing unneeded code.  The only problem (aside from this just being a guess anyway) is that I'd expect by this time I would have gotten used to l10n entities in random places and just ignored it.

Yes, the entity can probably be restored, especially since I don't remember the reason it was removed in the first place.  (I'd prefer if the entity were near the top of the file like it was before, tho, just from a stylistic standpoint.  Now's also probably a good time to do the entity rearrangement mentioned in the XXX comment as well.)

Comment 18

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 245651 [details] [diff] [review]
patch

r=me if you remove the commented out part of http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/components/preferences/sanitize.xul&rev=1.14&mark=53,54#53

Comment 19

[Asaf Romano (gone)]

Attachment: as checked in

mozilla/browser/base/content/sanitize.xul 1.15
mozilla/browser/components/preferences/sanitize.xul 1.15
mozilla/browser/locales/en-US/chrome/browser/sanitize.dtd 1.9