349488 - num_toLocaleString does not convert from locale encoding to Unicode

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Pascal Chevrel:pascalc (PTO until April 26)]

1 Display an image in a window like http://www.mozilla.com/images/firefox-logo-64x64.png

2 Open the page info dialog

Expected result : file size in bytes is 8 118
Actual result : file size in bytes is displayed 8Â 118

This bug can be seen with both Firefox 1.5.0.5 (Ubuntu Distro version) and 2.0b1 builds. 

It is not related to localisation since I can see the bug with an en-US version as well.

The bug does not show up on Windows, it was confirmed by 2 more people using Gnome/Ubuntu (don't know about KDE users).

Comment 1

[Pascal Chevrel:pascalc (PTO until April 26)]

Attachment: screenshot showing the bug

Here is a screenshot demonstrating the bug

Comment 2

[:Gavin Sharp [email: [e-mail]]]

This seems likely to be a problem with the linux implementation of toLocaleString (the page info dialog passes the number through that function before displaying it). Does |javascript:(1024).toLocaleString()| in the location bar give you the same strange result?

Comment 3

[Pascal Chevrel:pascalc (PTO until April 26)]

javascript:(1024).toLocaleString() does indeed produce the same error in Linux and not in Windows

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Pascal: could you provide the output of:
cat /usr/share/i18n/locales/<locale> | grep "thousands"
on the system that shows the bug, where <locale> is the configured system locale?

Comment 5

[Pascal Chevrel:pascalc (PTO until April 26)]

heren are the results :

cat /usr/share/i18n/locales/fr_FR | grep "thousands"

mon_thousands_sep         "<U00A0>"
thousands_sep             "<U00A0>"

Comment 6

[Simon Montagu :smontagu]

What the screenshot shows is 0xC2 0xA0, which is U+00A0 in UTF-8, displayed as if it were ISO-8859-1

Comment 7

[Simon Montagu :smontagu]

Attachment: Convert to Unicode

Comment 8

[Brendan Eich [:brendan]]

Comment on attachment 234836 [details] [diff] [review]
Convert to Unicode

Wow, how'd that get left out?  Does the implementation of that hook work correctly in this case?  Thanks,

/be

Comment 9

[Simon Montagu :smontagu]

The cases mentioned here work in fr_FR locale, but I would like to test it with something a bit more "solid" than a no-break-space if I can find an appropriate locale.

Comment 10

[Simon Montagu :smontagu]

There are no locales on my system that use any non-ASCII code points for thousands separator or decimal separator other than U+00A0, but I tested by hacking various values into the LC_NUMERIC file, and they all displayed correctly. 

Comment 11

[Brendan Eich [:brendan]]

Fix checked into trunk.

/be

Comment 12

[Mike Schroepfer]

Comment on attachment 234836 [details] [diff] [review]
Convert to Unicode

a=schrep for drivers - approving all [181approval pending] bugs now that the tree is open.

Comment 13

[Brendan Eich [:brendan]]

I committed Simon's patch to the 1.8 branch.

/be