Cannot attach popup and context menu to same XUL element

RESOLVED FIXED

Status

()

Core
XUL
RESOLVED FIXED
12 years ago
10 years ago

People

(Reporter: Neil Deakin, Assigned: smaug)

Tracking

({regression})

Trunk
x86
Mac OS X
regression
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

12 years ago
The change below is nsXULElement.cpp added in bug 286619 means that both a popup and context menu cannot be applied to the same element. See URL for testcase.

> nsresult
> nsXULElement::AddPopupListener(nsIAtom* aName)
> {
>+    nsCOMPtr<nsIXULPopupListener> popupListener =
>+        NS_STATIC_CAST(nsIXULPopupListener*,
>+                       GetProperty(nsXULAtoms::popuplistener));
>+    if (popupListener) {
>+        // Popup listener is already installed.
>+        return NS_OK;
>+    }

Comment 1

12 years ago
mailWidgets.xml also contains
<content popup="emailAddressPopup" context="emailAddressPopup">
(Assignee)

Updated

12 years ago
Assignee: nobody → Olli.Pettay
(Assignee)

Updated

12 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 2

12 years ago
Created attachment 234802 [details] [diff] [review]
proposed patch.

Sorry, my mistake.
I didn't want to change nsIXULPopupListener interface to use nsIAtoms as popup
types, so just using nsIAtoms as nsINode properties.
Attachment #234802 - Flags: review?(enndeakin)
(Reporter)

Updated

12 years ago
Attachment #234802 - Flags: review?(enndeakin) → review+
(Assignee)

Updated

12 years ago
Attachment #234802 - Flags: superreview?(bugmail)
Attachment #234802 - Flags: superreview?(bugmail) → superreview+
(Assignee)

Updated

12 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Updated

10 years ago
Component: XP Toolkit/Widgets: Menus → XUL
QA Contact: xptoolkit.menus → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.