349555 - Move dependency validation from post_bug into Bugzilla::Bug

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, enhancement)

Description

[Max Kanat-Alexander]

This is another in the series of "move validations into Bug.pm" bugs. This time it's for the "blocked" and "dependson" fields.

Comment 1

[Max Kanat-Alexander]

Attachment: v1

Okay, here it is! I've tested bug filing, and it all behaves properly. Changing bugs also still behaves properly.

Comment 2

[Olav Vitters]

Comment on attachment 234822 [details] [diff] [review]
v1

>Index: Bugzilla/Bug.pm

>@@ -349,6 +349,32 @@
>     return [keys %keyword_ids];
> }
> 
>+# Takes two comma/space-separated strings and returns arrayrefs
>+# of valid bug IDs.
>+sub _check_dependencies {
>+    my ($depends_on, $blocks) = @_;
>+
>+    # Only editbugs users can set dependencies on bug entry.
>+    return ([], []) unless Bugzilla->user->in_group('editbugs');
>+
>+    # Make sure all the bug_ids are valid.
>+    my @results;
>+    foreach my $string ($depends_on, $blocks) {
>+        my @array = split(/[\s,]+/, $string);

Those strings can be undef:

[Tue Aug 22 23:15:49 2006] [error] [client 127.0.0.1] [Tue Aug 22 23:15:49 2006] post_bug.cgi: Use of uninitialized value in split at Bugzilla/Bug.pm line 363.
[Tue Aug 22 23:15:49 2006] [error] [client 127.0.0.1] [Tue Aug 22 23:15:49 2006] post_bug.cgi: Use of uninitialized value in split at Bugzilla/Bug.pm line 363.

Looks good reading through it otherwise.

Comment 3

[Max Kanat-Alexander]

Attachment: v2

Okay, this handles that.

Comment 4

[Max Kanat-Alexander]

Checking in post_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/post_bug.cgi,v  <--  post_bug.cgi
new revision: 1.168; previous revision: 1.167
done
Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.142; previous revision: 1.141
done