349565 - New Qute theme toolbar buttons have different heights

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Alex Ihrig [:Thunderbird_Mail_DE]]

Have a look at the screenshot.

Comment 1

[Alex Ihrig [:Thunderbird_Mail_DE]]

Attachment: Screenshot demonstrating the problem

Comment 2

[Scott MacGregor]

I think this is happening because the history buttons are of type type="menu-button". This causes us to pick up some style rules from toolkit which aren't working well with the new theme I think.

This same bug is present with the print and mark toolbar buttons as well which are also menu-buttons.

Comment 3

[Alex Ihrig [:Thunderbird_Mail_DE]]

(In reply to comment #2)
> I think this is happening because the history buttons are of type
> type="menu-button".

Changing all buttons from type "menu-button" to "menu" solves the problem. But this behaviour will break all Add-ons using buttons from type "menu-button".

Comment 4

[Alex Ihrig [:Thunderbird_Mail_DE]]

Wahhhh, be carefull. Buttons from type "menu" (see the tags button) don't have the optical separator between the buttons icon and the small down triangel. Some menu-buttons (see tags button) open the menu by clicking the button (it's not necessary to click explicit the triangel). But other buttons (see my extensions "MagicSLR" or "Allow HTML temporary" distinguish between clicking the icon OR the triangel. Clicking the icon has an own function, clicking the triangel opens the menu.

We should save the separator line between the buttons icon and the triangel. Or we need a new different button type in CSS, which has the separator line. This would give us the option to distinguish between different menu button types.

Comment 5

[Alex Ihrig [:Thunderbird_Mail_DE]]

And one more thing. Button type="menu" _breaks_ the classic menu buttons. For example the button "Mark" had an own function in the past, when I was clicking the button itself (mark read or unread). Only clicking the triangel opened the menu in the past (the same as in my Add-ons).
Now using button type "menu", the button "Mark" is no more functional - only the menu opens.
In my previous comments, I wasn't aware of this fact.

So we _must_ save the button type "menu-button" and correct the CSS.

Comment 6

[Scott MacGregor]

the latest patch in Bug 349565 fixes this problem.