Closed Bug 349617 Opened 18 years ago Closed 18 years ago

Need process and test to avoid incorrect redirect rewrites being deployed to AMO production system (Unable to install any theme Jar Files)

Categories

(mozilla.org Graveyard :: Server Operations, task)

task
Not set
major

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 349636

People

(Reporter: marcia, Unassigned)

Details

Seen using Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1b2) Gecko/20060821 Firefox/2.0b2, but I have tried this on other builds as well and get the same results.

STR:

1. Try to install a theme that is compatible with FF Beta2 candidate
2. Click on Install now

Receive a dialog that allows you to save the JAR file or open it. saving the file and dragging to the browser window doesn't initiate the JAR install process.

We need this fixed ASAP since we are deep in the midst of testing Beta2.
Flags: blocking-firefox2?
Target Milestone: --- → 0.9
First report of this problem in #addons was at 4:55PM PST.
Target Milestone: 0.9 → ---
Target Milestone: --- → 0.9
I get "installTheme is not defined" in the JS console.  Possibly related to the fact that https://addons.mozilla.org/js/install.js redirects to https://addons.mozilla.org/install.js, which doesn't exist.

Paging ops.
I also noticed that oremj posted a bunch of redirection/rewrite stuff on bug 348568 20 minutes after this started, so that may be the install.js problem.
There was a bad redirect config added to the addons.mozilla.org vhost for some reason; I wasn't aware that such a change was being made, but I might not be on the right bug or whatever.

Reassigning to server-ops for post-mortem and description of whatever process/test changes are needed to make sure that future server config changes don't adversely affect unrelated services.  (With the web server logs, it seems like an hour's work or so to write a tool to verify that the same URLs are redirected or not, for A/B verification in the staging environment.  Please cc: me on any bugs that are splintered off to cover that work; I am rather invested in it.)
Assignee: nobody → server-ops
Severity: blocker → major
Component: Add-ons → Server Operations
Flags: blocking-firefox2?
Product: addons.mozilla.org → mozilla.org
QA Contact: add-ons → justin
Summary: Unable to install any theme Jar Files → Incorrect redirect rewrites deployed to AMO production system (Unable to install any theme Jar Files)
Target Milestone: 0.9 → ---
Version: unspecified → other
OS: Mac OS X 10.4 → All
Hardware: Macintosh → All
Assignee: server-ops → oremj
RewriteRule ^(\w{2}(-\w{2}(-mac)?)?)/(.*)$ /$4 [R]

That was the rewrite that broke it. 
:-(

Removing until a better rule is written. 
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Reopening and returning to the queue for the post-mortem and description of process/test changes, as in comment 4.  Re-summarizing so that it's clearer too; apologies for my late-night summary.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Summary: Incorrect redirect rewrites deployed to AMO production system (Unable to install any theme Jar Files) → Need process and test to avoid incorrect redirect rewrites being deployed to AMO production system (Unable to install any theme Jar Files)
Assignee: oremj → server-ops
Status: REOPENED → NEW
I belive this will be solved with the staging infra - please let me know if you disagree.

*** This bug has been marked as a duplicate of 349636 ***
Status: NEW → RESOLVED
Closed: 18 years ago18 years ago
Resolution: --- → DUPLICATE
I do disagree: having a staging environment is necessary but not sufficient, in that it doesn't give us a sense of what is tested and how, before changes are pushed live.  We have a staging environment for addons today, albeit a low-fidelity one (khan), and it didn't save us from this problem because of process issues, not because of inadequately high-fidelity staging capability.
Product: mozilla.org → mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.