Closed Bug 349650 Opened 18 years ago Closed 18 years ago

Number getting parens replaces last character of identifier in decompilation of array comprehension

Categories

(Core :: JavaScript Engine, defect, P2)

defect

Tracking

()

VERIFIED FIXED
mozilla1.8.1

People

(Reporter: jruderman, Assigned: brendan)

References

Details

(Keywords: testcase, verified1.8.1)

Attachments

(1 file)

> function() { [5[7] for (y in window)]; }

function () { [(5)[7] for (y in windo(5)]; }

There should be a "w" where the second "(5" is.
Attached patch fixSplinter Review
One-line fix to new-in-js1.7 array comprehension decompilation bug.  This is the necessary step from PushOff, inlined and minimized to operate on the existing top of stack (like pop; push with all the stack top manipulation canceled out).

/be
Assignee: general → brendan
Status: NEW → ASSIGNED
Attachment #235855 - Flags: review?(mrbkap)
Attachment #235855 - Flags: approval1.8.1?
Attachment #235855 - Flags: review?(sayrer)
OS: Mac OS X 10.4 → All
Priority: -- → P2
Hardware: Macintosh → All
Target Milestone: --- → mozilla1.8.1
Attachment #235855 - Flags: review?(sayrer) → review+
Attachment #235855 - Flags: review?(mrbkap) → review+
Fixed on trunk.

/be
Blocks: geniter
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Comment on attachment 235855 [details] [diff] [review]
fix

a=beltzner on behalf of the 181drivers
Attachment #235855 - Flags: approval1.8.1? → approval1.8.1+
Fixed on the 1.8 branch.

/be
Keywords: fixed1.8.1
Checking in regress-349650.js;
/cvsroot/mozilla/js/tests/js1_5/Regress/regress-349650.js,v  <--  regress-349650.js
initial revision: 1.1
Flags: in-testsuite+
verified fixed 1.8, 1.9 20060830 windows/mac*/linux
Status: RESOLVED → VERIFIED
Blocks: 380506
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: