Closed
Bug 349650
Opened 18 years ago
Closed 18 years ago
Number getting parens replaces last character of identifier in decompilation of array comprehension
Categories
(Core :: JavaScript Engine, defect, P2)
Core
JavaScript Engine
Tracking
()
VERIFIED
FIXED
mozilla1.8.1
People
(Reporter: jruderman, Assigned: brendan)
References
Details
(Keywords: testcase, verified1.8.1)
Attachments
(1 file)
1.15 KB,
patch
|
mrbkap
:
review+
sayrer
:
review+
beltzner
:
approval1.8.1+
|
Details | Diff | Splinter Review |
> function() { [5[7] for (y in window)]; }
function () { [(5)[7] for (y in windo(5)]; }
There should be a "w" where the second "(5" is.
Assignee | ||
Comment 1•18 years ago
|
||
One-line fix to new-in-js1.7 array comprehension decompilation bug. This is the necessary step from PushOff, inlined and minimized to operate on the existing top of stack (like pop; push with all the stack top manipulation canceled out).
/be
Assignee: general → brendan
Status: NEW → ASSIGNED
Attachment #235855 -
Flags: review?(mrbkap)
Attachment #235855 -
Flags: approval1.8.1?
Assignee | ||
Updated•18 years ago
|
Attachment #235855 -
Flags: review?(sayrer)
Assignee | ||
Updated•18 years ago
|
OS: Mac OS X 10.4 → All
Priority: -- → P2
Hardware: Macintosh → All
Target Milestone: --- → mozilla1.8.1
Updated•18 years ago
|
Attachment #235855 -
Flags: review?(sayrer) → review+
Updated•18 years ago
|
Attachment #235855 -
Flags: review?(mrbkap) → review+
Assignee | ||
Comment 2•18 years ago
|
||
Fixed on trunk.
/be
Comment 3•18 years ago
|
||
Comment on attachment 235855 [details] [diff] [review]
fix
a=beltzner on behalf of the 181drivers
Attachment #235855 -
Flags: approval1.8.1? → approval1.8.1+
Comment 5•18 years ago
|
||
Checking in regress-349650.js;
/cvsroot/mozilla/js/tests/js1_5/Regress/regress-349650.js,v <-- regress-349650.js
initial revision: 1.1
Flags: in-testsuite+
Comment 6•18 years ago
|
||
verified fixed 1.8, 1.9 20060830 windows/mac*/linux
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.1 → verified1.8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•