349670 - Password manager doesn't show password anymore

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Jean-Michel Reghem]

TB 2.0a1 build 2006082107  (same bug for 20060820).
14 pop account, all with password saved in TB ...
In the current 2.0 build, the password manager doesn't show the password (and doesn't show username)

Reproducible: always
Step to reproduce: Tools -> Option -> Privacy -> Password -> View Saved Password:
The list of username/password is empty, even after clicking on "view password" button. (see screenshot)

Comment 1

[Jean-Michel Reghem]

Attachment: Saved password list is empty

Comment 2

[Magnus Melin [:mkmelin]]

Confirmed on Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1b2) Gecko/20060822 Thunderbird/2.0a1 ID:2006082203

Error: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.GetStringFromName]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: XStringBundle :: getString :: line 17"  data: no]

Regressionwindow
Ok: 2006-08-19
Broken: 2006-08-20

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=ThunderbirdTinderbox&branch=MOZILLA_1_8_BRANCH&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-08-19&maxdate=2006-08-20&cvsroot=%2Fcvsroot

Bug 337475 seems like the very likely culprit.

Comment 3

[Peter Weilbacher]

When I enable dumps I get
   *** Failed to get string noUserNameForPassword in bundle:
   chrome://communicator/locale/wallet/SignonViewer.properties
so it wasn't bug 337475 directly. It looks more like the wrong SignonViewer.properties gets packaged for Thunderbird, the one from mail/locales/en-US/chrome/communicator/wallet has this string.

It also suggests that we may need to add the two properties from bug 337475 to this file, too (or the other way around, add noUserNameForPassword to the file in extensions/...). But I know nothing about Thunderbird so I better wait for someone to tell me which would be the right way to proceed.

Comment 4

[Scott MacGregor]

Attachment: the fix

forces jar.mn to use thunderbird's locale files for wallet. I'm not sure why we are picking up the ones in extension\wallet. Maybe those should be wrapped in a #ifndef moz xul app.

I also implemented the feature that got added to seamonkey.

Not sure why the patch says there is no new line at the end of the .properties file, I've confirmed that there is one.

Comment 5

[Scott MacGregor]

fixed on the branch and trunk.

Comment 6

[Jean-Michel Reghem]

ok, wfm now with 2.0a1 2006082221
thanks a lot :-)