349713 - compare-locales should support reasonable numbers of Feed contentHandler webservices

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[dynamis (Tomoya ASAI)]

In trademarks reviews for 2.0, we permitted locales to have less or more ordered Feed contentHandler webservices than the four we have in en-US, compare-locales should support that.
http://lxr.mozilla.org/mozilla1.8/source/browser/locales/en-US/chrome/browser-region/region.properties#10
is the reference.

This bug should be resolved same as bug 316674.
c.f. Japanese builds will have six feed contenthandlers (bug 347828).

Comment 1

[Axel Hecht [:Pike]]

Attachment: drop uninstaller.inc ignore, add browser.contentHandlers

Benjamin, the hack about uninstaller.inc is no longer needed on both trunk and 1.8 branch, so I removed that.
I did add browser.contentHandlers.types.[0-5], 0-5 as those are the number of handlers redirecting in firefox.js,
http://lxr.mozilla.org/mozilla/source/browser/app/profile/firefox.js#470

Comment 2

[Axel Hecht [:Pike]]

Comment on attachment 237428 [details] [diff] [review]
drop uninstaller.inc ignore, add browser.contentHandlers

http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-l10n/1157986547.2452.gz&fulltext=1 is the build after landing this on the trunk,
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-l10n/1157980012.12781.gz&fulltext=1 is the one before.

fr and pl went from testfailed to success, no locale the other way around.

Build only change to get builds that are ok green, requesting branch approval.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 237428 [details] [diff] [review]
drop uninstaller.inc ignore, add browser.contentHandlers

a=beltzner on behalf of 181drivers

Comment 4

[Axel Hecht [:Pike]]

This doesn't really block the fx20l10n bug, and it's fixed on trunk and branch.

Comment 5

[Axel Hecht [:Pike]]

duh, logic. Reopening.

Comment 6

[Axel Hecht [:Pike]]

Attachment: get and and or and ! and stuff right.

Dang, getting review is just not enough when it comes down to boolean logic.

What should happen is:

If I'm not in region.properties OR
if my entity doesn't match A AND odesn't match B
-> add this entity to the list of entities to add.

The previous version ignores any missing entity in region.properties, turning el green on tinderbox, which it shouldn't.

Comment 7

[Axel Hecht [:Pike]]

Comment on attachment 239005 [details] [diff] [review]
get and and or and ! and stuff right.

We need to land this fix to get the tinderbox status closer to the status of http://people.mozilla.com/~axel/status-1.8/, which is *way* confusing for l10n work and releasing.
No code change, just tool.

Comment 8

[Mike Schroepfer]

Comment on attachment 239005 [details] [diff] [review]
get and and or and ! and stuff right.

a=schrep for build tool bug

Comment 9

[Axel Hecht [:Pike]]

FIXED on trunk and branch since 2006-09-18 10:55, forgot to update the bug after waiting on l10n builds for regressions.