349757 - show only this frame is broken

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060822 Minefield/3.0a1 ID:2006082211 [cairo]

repro:

1.open a page with frames
2.rightclick inside a frame and select "show only this frame"

result:
nothing happens

this regressed between:
works in firefox-3.0a1.en-US.win32_20060821_0843pdt build
fails in firefox-3.0a1.en-US.win32_20060821_1248pdt build

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&filetype=match&whotype=match&sortby=Date&hours=2&date=explicit&mindate=20060821+0800&maxdate=20060821+1245&cvsroot=%2Fcvsroot

Ria, can you narrow it down any further ?

Comment 1

[:Gavin Sharp [email: [e-mail]]]

This is probably my fault, looking...

Comment 2

[Peter van der Woude [:Peter6]]

Open this frame in a new window / tab
still works

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch (-w)

Oops, this is a stupid mistake. I was sure I'd tested this... I'll just check this in, it's an obvious fix.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Checked this in with a whitespace fix. I'll make sure to include this fix in the branch patch for bug 335334.
mozilla/browser/base/content/browser.js 	1.690

Comment 5

[:Gavin Sharp [email: [e-mail]]]

And thanks a bunch for finding this as quick as you did, Peter :)

Comment 6

[Peter van der Woude [:Peter6]]

at your service Gavin ;-)

Comment 7

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060822 Minefield/3.0a1 ID:2006082220 [cairo]

verified/fixed