Closed Bug 349841 Opened 14 years ago Closed 14 years ago

When about dialog is opened from a non-browser window (e.g. Bookmarks Manager), "Friends" and "Contributors" links do not work

Categories

(Firefox :: General, defect, minor)

2.0 Branch
defect
Not set
minor

Tracking

()

RESOLVED FIXED
Firefox 2

People

(Reporter: kilowatt, Assigned: Gavin)

Details

(Keywords: fixed1.8.1)

Attachments

(1 file, 3 obsolete files)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060822 BonEcho/2.0b2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060822 BonEcho/2.0b2

When about dialog is opened from Bookmarks Manager, Friends or Contributors page does not appear anywhere - nor tab, nor window, and scrolling text in about dialog restarts scrolling from the top.

Reproducible: Always

Steps to Reproduce:
1. Open Bookmarks Manager
2. Open Help -> About...
3. Click on Credits button
4. Click on Friends or Contributors link

Actual Results:  
Nothing happens.

Expected Results:  
New tab/window should open with Friends or Contributors page.
Not sure if this is a dupe or not yet, but this is definitely not working. :/

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060822 BonEcho/2.0b2 ID:2006082203
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: blocking-firefox2?
Target Milestone: --- → Firefox 2
Version: unspecified → 2.0 Branch
Attached patch hack (obsolete) — Splinter Review
Flags: blocking-firefox2? → blocking-firefox2+
Is there really even a reason to have these menu entries in the Bookmark Manager?

Help ->
  Release Notes
  Check For Updates
  About Bon Echo

Seems like these should just be removed. [Help -> Help Contents would be the only item remaining.]
There are such menu items in "Page Source" and "DOM Source" windows, and they do work. Should they also be removed?
Attached patch different hack (obsolete) — Splinter Review
I'm not sure which one I prefer.
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attached patch real different hack (obsolete) — Splinter Review
Attachment #235109 - Attachment is obsolete: true
There's also the same problem with the DOM Inspector window.
Summary: When about dialog is opened from Bookmarks Manager, Friends or Contributors page does not appear → When about dialog is opened from a non-browser window (e.g. Bookmarks Manager), "Friends" and "Contributors" links do not work
OS: Windows XP → All
Hardware: PC → All
Comment on attachment 235110 [details] [diff] [review]
real different hack

This has issues with launching the window from a modal dialog.
Attachment #235110 - Attachment is obsolete: true
Attached patch patchSplinter Review
The first hack also didn't work when the opening window was closed (or for Mac where the "no window" case is more common). This should work consistently across the board.
Attachment #235076 - Attachment is obsolete: true
Attachment #235163 - Flags: review?(bugs.mano)
Whiteboard: [patch-r?]
Whiteboard: [patch-r?] → [checkin needed]
mozilla/toolkit/content/globalOverlay.js 	1.26
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Attachment #235163 - Flags: approval1.8.1?
Comment on attachment 235163 [details] [diff] [review]
patch

a=beltzner on behalf of the 181drivers
Attachment #235163 - Flags: approval1.8.1? → approval1.8.1+
mozilla/toolkit/content/globalOverlay.js 	1.18.8.7

I filed bug 350205 on making this code work for non-browser consumers (Tb, Sunbird)
Keywords: fixed1.8.1
You need to log in before you can comment on or make changes to this bug.