349854 - Search Engine Reordering doesn't stick after pressing the OK button and unclean exit

Status: RESOLVED WONTFIX

(Firefox :: Search, defect)

Description

[Jean-Yves Perrier [:teoli]]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1b2) Gecko/20060822 BonEcho/2.0b2
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1b2) Gecko/20060822 BonEcho/2.0b2

One expects that when we press the Ok button in the Search Engine Manager, the new ordering will stick permanently.

However, if Fx does not shut down gracefully afterwards, the new ordering is lost

Reproducible: Always

Steps to Reproduce:
1.Reorder the Search Engines using the Search Engine Manager (SEM).
2.Press the OK button of the SEM
3.Close firefox non-gracefully (by a kill -9 for example)

Actual Results:  
New ordering of SE is not remembered

Expected Results:  
Ordering of SE should be the same as right after the pressing of the OK button.

It seems that the state of the SEM is stored only when we close Firefox; the user expect that this state should be stored when he presses the OK button of the SEM.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Because of the way we save ordering information, killing the app that way will cause the order to not be remembered. I'm not really sure if this problem is worth fixing - there are other things that are lost after a hard shutdown, and engine ordering information is hardly critical. We could probably save on a timeout or something, or even save immediately after the change is made - I forget why I didn't do that originally.

Comment 2

[Liz Henry (:lizzard) (relman/hg->git project)]

This is still reproducible.

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

I'm not sure if this apply to the new in-content Search preferences, that are instant-apply, but regardless it would be true for any other pref managed in the same way, so not worth fixing.